Fix PyPI upload #407
Merged
Fix PyPI upload #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanheerdegen
previously approved these changes
Jan 22, 2024
| with: | ||
| path: artifact/ | ||
| name: release | ||
| path: dist |
There was a problem hiding this comment.
I noticed these didn't match, but just assumed this was correct. I guess it wasn't?
There was a problem hiding this comment.
Yeah. The strange thing is that I haven't touched these...
There was a problem hiding this comment.
Best guess is it had to do with the version change of the pypi-publish action
|
Sorry forgot one thing. Just tested publishing to TestPyPI from my fork and these changes fixed the issue. |
aidanheerdegen
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyPI upload stopped working after #403 was merged. I can't say I understand why as #403 didn't touch the workflow steps that are causing the problem... Regardless, this PR should fix things.
The update to
actions/upload-artifact@v4(fromv3) is not necessary to fix the issue, but good to do anyway.Closes #398 (again)