-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check for MOM6 parameter filenames defined in input.nml #364
Add a check for MOM6 parameter filenames defined in input.nml #364
Conversation
Hello @jo-basevi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-10-04 01:19:44 UTC |
631a372
to
15046e2
Compare
15046e2
to
5afdd8a
Compare
5afdd8a
to
8ace7f6
Compare
I would have asked @angus-g for a review, but he wasn't a team member. Have added him, so he should be able to review this. |
I've pinged you for a review @angus-g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a much nicer way of dealing with things! I've left a comment on how to take this a bit further to tidy up the lists of config files.
a054ebb
to
b26543e
Compare
If parameter file is not in mom6's hardcoded files, it is added to the config file and moved to the work directory
- Add a warning when there's no parameter files for MOM_input_nml or (SIS_input_nml if present)
b26543e
to
ab80d20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks @jo-basevi, this looks good now!
In this branch, I've tagged on some code that runs at the end of
Mom6.setup()
that checks if files listed inparameter_file
ofMOM_input_nml
andSIS_input_nml
namelists in input.nml, are included in mom6's hard codedconfig_files
oroptional_config_files
.If the file is not present, I've added a warning, added the file to
config_files
and then copied the file to the workpath.Or is just a warning/error printed out during setup sufficient? If not, should the files be treated as
config_files
oroptional_config_files
- i.e. raises an exception if file not found or not?From what I can tell, the only usages of
optional_config_files
andconfig_files
are:Should close #325