Read mom6 parameter files in cesm cmeps driver #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat! I've pinged @dougiesquire and @angus-g for a review. Angus, don't worry if you have no opinion, just wanted to keep you in the loop as this reuses the code @jo-basevi just added to the mom6 driver. |
dougiesquire
approved these changes
Oct 17, 2023
jo-basevi
pushed a commit
to jo-basevi/payu
that referenced
this pull request
Nov 8, 2023
…est for mom6 setup
jo-basevi
added a commit
that referenced
this pull request
Nov 8, 2023
Fix bug copying mom6 config files introduced in #373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the code added in #364, so it can also be re-used for the
momcomponent incesm-cmepsdriver.I didn't add in
mixinclass in the end, as it just needed only one function (mom6_add_parameter_files) which I broke out ofmom6driver class. Though please let me know if using amixinclass would still be better!Should close #371