Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show instructions for failed build #457

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Do not show instructions for failed build #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 38 additions & 35 deletions frontend/src/components/copr/CoprBuild.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,41 +75,44 @@ export const CoprBuild = () => {
<CoprBuildDetail data={data} />
</CardBody>
</Card>
<Card>
<CardBody>
<Text component="p">
<strong>
You can install the built RPMs by following these steps:
</strong>
</Text>
<br />
<List>
<ListItem>
<code>sudo dnf install -y dnf-plugins-core</code>
</ListItem>
<ListItem>
<code>
sudo dnf copr enable {data.copr_owner}/{data.copr_project}
</code>
</ListItem>
{data.built_packages ? (
<ListItem>
<code>
sudo dnf install -y{" "}
{getPackagesToInstall(data.built_packages).join(" ")}
</code>
</ListItem>
) : (
<></>
)}
</List>
<Text component="p">
<br />
Please note that the RPMs should be used only in a testing
environment.
</Text>
</CardBody>
</Card>

{data.built_packages ? (
<>
<Card>
<CardBody>
<Text component="p">
<strong>
You can install the built RPMs by following these steps:
</strong>
</Text>
<br />
<List>
<ListItem>
<code>sudo dnf install -y dnf-plugins-core</code>
</ListItem>
<ListItem>
<code>
sudo dnf copr enable {data.copr_owner}/{data.copr_project}
</code>
</ListItem>
<ListItem>
<code>
sudo dnf install -y{" "}
{getPackagesToInstall(data.built_packages).join(" ")}
</code>
</ListItem>
</List>
<Text component="p">
<br />
Please note that the RPMs should be used only in a testing
environment.
</Text>
</CardBody>
</Card>
</>
Comment on lines +80 to +112
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, don't need React Fragment here <> as we only need it when there are multiple top-level components. Here we just have <Card>

) : (
<></>
)}
</PageSection>
</>
);
Expand Down
Loading