-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not show instructions for failed build #457
Conversation
Build succeeded. ✔️ pre-commit SUCCESS in 2m 37s |
d3442d1
to
0bbaf1d
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 2m 28s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
<> | ||
<Card> | ||
<CardBody> | ||
<Text component="p"> | ||
<strong> | ||
You can install the built RPMs by following these steps: | ||
</strong> | ||
</Text> | ||
<br /> | ||
<List> | ||
<ListItem> | ||
<code>sudo dnf install -y dnf-plugins-core</code> | ||
</ListItem> | ||
<ListItem> | ||
<code> | ||
sudo dnf copr enable {data.copr_owner}/{data.copr_project} | ||
</code> | ||
</ListItem> | ||
<ListItem> | ||
<code> | ||
sudo dnf install -y{" "} | ||
{getPackagesToInstall(data.built_packages).join(" ")} | ||
</code> | ||
</ListItem> | ||
</List> | ||
<Text component="p"> | ||
<br /> | ||
Please note that the RPMs should be used only in a testing | ||
environment. | ||
</Text> | ||
</CardBody> | ||
</Card> | ||
</> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, don't need React Fragment here <>
as we only need it when there are multiple top-level components. Here we just have <Card>
Fixes #383
TODO:
packit/packit.dev
.Fixes
Related to
Merge before/after
RELEASE NOTES BEGIN
Don't show instructions for installation when build fails
RELEASE NOTES END