Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deps installation in makefile and adjust docs #456

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −2
Open

Fix deps installation in makefile and adjust docs #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
babbd24
chore: install npm and corepack via makefile
mfocko Sep 26, 2024
16a1c87
docs: mention userspace setup of npm in contributing
mfocko Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ Please follow common guidelines for our projects [here](https://github.com/packi

## Guidelines for Developers

### Dependencies

`make install-dependencies` automatically installs `nodejs` and `npm` for you,
and additionally also `corepack` via `npm`. In case the installation fails,
follow [this](https://docs.npmjs.com/resolving-eacces-permissions-errors-when-installing-packages-globally)
guide to set up a directory for `npm` in your home directory.
Comment on lines +14 to +17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's included in NodeJS v16 and above it should just work without issue so seems unnecessary in that case

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If dnf install works we can probably remove this


### Naming Scheme

- `camelCase` for variable names.
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ GIT_SHA_FETCH := $(shell git rev-parse HEAD)
export GIT_SHA=$(GIT_SHA_FETCH)

install-dependencies: .install-logos
sudo dnf -y install python3-flask python3-flask-cors python3-flask-talisman
corepack enable pnpm
sudo dnf -y install python3-flask python3-flask-cors python3-flask-talisman pnpm

cd frontend && pnpm install
make transpile-prod

Expand Down
Loading