Fix deps installation in makefile and adjust docs #456
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 13s |
Makefile
Outdated
| sudo dnf -y install python3-flask python3-flask-cors python3-flask-talisman npm | ||
| npm install -g corepack | ||
|
|
There was a problem hiding this comment.
Note sure which version but we can install NodeJS>16 to get corepack
| sudo dnf -y install python3-flask python3-flask-cors python3-flask-talisman npm | |
| npm install -g corepack | |
| sudo dnf -y install python3-flask python3-flask-cors python3-flask-talisman nodejs | |
There was a problem hiding this comment.
mfocko@ampere
~ % node --version
v20.17.0
mfocko@ampere
~ % corepack
zsh: corepack: command not found...
uhh…
There was a problem hiding this comment.
Huh..
We can change it around to just install pnpm. dnf install pnpm. Might be better. Then we don't need corepack enable pnpm below either
There was a problem hiding this comment.
Try this
| sudo dnf -y install python3-flask python3-flask-cors python3-flask-talisman npm | |
| npm install -g corepack | |
| sudo dnf -y install python3-flask python3-flask-cors python3-flask-talisman pnpm |
📦[spytec@fedora-rawhide]~% dnf search pnpm --showduplicates
Updating and loading repositories:
Repositories loaded.
Matched fields: name (exact)
pnpm-0:9.11.0-1.fc42.noarch: Fast, disk space efficient package manager
| `make install-dependencies` automatically installs `nodejs` and `npm` for you, | ||
| and additionally also `corepack` via `npm`. In case the installation fails, | ||
| follow [this](https://docs.npmjs.com/resolving-eacces-permissions-errors-when-installing-packages-globally) | ||
| guide to set up a directory for `npm` in your home directory. |
There was a problem hiding this comment.
If it's included in NodeJS v16 and above it should just work without issue so seems unnecessary in that case
There was a problem hiding this comment.
If dnf install works we can probably remove this
mfocko
force-pushed
the
fix/deps-in-makefile
branch
from
d52a5ae
to
22acae9
Compare
|
Preview: https://packit-dashboard-pr-456.surge.sh (deployed at Tue 01 Oct 2024, 12:10 UTC) |
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 10s |
Co-authored-by: Freya Gustavsson <[email protected]> Signed-off-by: Matej Focko <[email protected]>
Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
fix/deps-in-makefile
branch
from
22acae9
to
16a1c87
Compare
|
Build failed. ❌ pre-commit POST_FAILURE in 2m 01s |
|
recheck |
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 12s |
No description provided.