Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pipeline detail view #417

Merged
merged 6 commits into from
Jun 26, 2024
Merged

feat: Pipeline detail view #417

merged 6 commits into from
Jun 26, 2024

Conversation

Venefilyn
Copy link
Collaborator

Commit message to be changed, still in draft.

Results so far
image

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.
  • ‹fill in›

Fixes

Related to

Merge before/after

RELEASE NOTES BEGIN
Introduce detail page for individual pipelines
RELEASE NOTES END

@Venefilyn Venefilyn marked this pull request as draft June 5, 2024 16:29
@usercont-release-bot
Copy link

usercont-release-bot commented Jun 5, 2024 •
edited
Loading

Preview: https://packit-dashboard-pr-417.surge.sh (deployed at Wed 26 Jun 2024, 13:27 UTC)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d2bf7408cff64c14bec00fb0ba39a2f8

✔️ pre-commit SUCCESS in 1m 48s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/6181de88dfc548fa98d7fe8258a1b467

✔️ pre-commit SUCCESS in 1m 45s

@Venefilyn Venefilyn marked this pull request as ready for review June 6, 2024 00:45
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/1c5a57d26dc34a30ab0bdfe9b48225ce

✔️ pre-commit SUCCESS in 1m 57s

lbarcziova
lbarcziova reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great so far!

frontend/src/app/Pipelines/PipelinesTable.tsx Show resolved Hide resolved
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c32a82926da74405a051f43f4d6dae1b

❌ pre-commit FAILURE in 1m 44s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/b3efdaaec3f942cfb6134c2acb856eea

✔️ pre-commit SUCCESS in 1m 58s

lbarcziova
lbarcziova reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visually looks great!

frontend/src/app/Pipelines/PipelineDetail.tsx Show resolved Hide resolved
@lbarcziova lbarcziova mentioned this pull request Jun 25, 2024
Merged
softwarefactory-project-zuul bot added a commit to packit/packit-service that referenced this pull request Jun 25, 2024
@softwarefactory-project-zuul
Order merged pipelines in get_merged_run (#2452)
e0fc2f5 
Order merged pipelines in get_merged_run

So that the correct one is returned.
I hope this could help with packit/dashboard#417 (comment), but wasn't able to test it locally.
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

Reviewed-by: Matej Focko
lbarcziova
lbarcziova approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one more thing, could we change the order of the elements so that it is

  • Copr builds, Tests, Propose downstream in the first column
  • Pull from upstream, Koji build, Bodhi update in the second?

from the pipeline steps perspective it makes better sense

@Venefilyn
Copy link
Collaborator Author

@lbarcziova something like this?

image
image

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/27e26bb0fffa4fdebf06523af62ab543

✔️ pre-commit SUCCESS in 1m 54s

@Venefilyn Venefilyn added this pull request to the merge queue Jun 26, 2024
Merged via the queue into packit:main with commit 4c7a27e Jun 26, 2024
4 checks passed
@Venefilyn Venefilyn deleted the feat/pipeline-detail branch June 26, 2024 16:39
@lachmanfrantisek lachmanfrantisek mentioned this pull request Jul 15, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Venefilyn @usercont-release-bot @lbarcziova