Skip to content

Commit

Permalink
Improved layout of pipeline details
Browse files Browse the repository at this point in the history
  • Loading branch information
Venefilyn committed Jun 26, 2024
1 parent fa19965 commit 35dcd56
Showing 1 changed file with 23 additions and 35 deletions.
58 changes: 23 additions & 35 deletions frontend/src/app/Pipelines/PipelineDetail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -184,22 +184,6 @@ const PipelineDetail = () => {
</Text>
)}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Submitted time</DescriptionListTerm>
<DescriptionListDescription>
{data?.time_submitted ? (
<Timestamp stamp={data.time_submitted.toString()} />
) : isLoading ? (
<Skeleton width="150px" />
) : (
<Text component={TextVariants.small}>
<i>Not available</i>
</Text>
)}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Copr builds</DescriptionListTerm>
<DescriptionListDescription>
{data?.copr.length ? (
Expand All @@ -216,15 +200,13 @@ const PipelineDetail = () => {
</Text>
)}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Koji builds</DescriptionListTerm>
<DescriptionListTerm>Testing Farm runs</DescriptionListTerm>
<DescriptionListDescription>
{data?.koji.length ? (
{data?.test_run.length ? (
<Statuses
route={"koji-builds"}
route={"testing-farm"}
statusClass={StatusLabel}
entries={data.koji}
entries={data.test_run}
/>
) : isLoading ? (
<Skeleton width="150px" />
Expand All @@ -234,8 +216,6 @@ const PipelineDetail = () => {
</Text>
)}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Propose Downstreams</DescriptionListTerm>
<DescriptionListDescription>
{data?.propose_downstream.length ? (
Expand All @@ -254,13 +234,25 @@ const PipelineDetail = () => {
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Pull From Upstreams</DescriptionListTerm>
<DescriptionListTerm>Submitted time</DescriptionListTerm>
<DescriptionListDescription>
{data?.time_submitted ? (
<Timestamp stamp={data.time_submitted.toString()} />
) : isLoading ? (
<Skeleton width="150px" />
) : (
<Text component={TextVariants.small}>
<i>Not available</i>
</Text>
)}
</DescriptionListDescription>
<DescriptionListTerm>Koji builds</DescriptionListTerm>
<DescriptionListDescription>
{data?.koji.length ? (
<Statuses
route={"pull_from_upstream"}
route={"koji-builds"}
statusClass={StatusLabel}
entries={data.pull_from_upstream}
entries={data.koji}
/>
) : isLoading ? (
<Skeleton width="150px" />
Expand All @@ -270,15 +262,13 @@ const PipelineDetail = () => {
</Text>
)}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Testing Farm runs</DescriptionListTerm>
<DescriptionListTerm>Pull From Upstreams</DescriptionListTerm>
<DescriptionListDescription>
{data?.test_run.length ? (
{data?.koji.length ? (
<Statuses
route={"testing-farm"}
route={"pull_from_upstream"}
statusClass={StatusLabel}
entries={data.test_run}
entries={data.pull_from_upstream}
/>
) : isLoading ? (
<Skeleton width="150px" />
Expand All @@ -288,8 +278,6 @@ const PipelineDetail = () => {
</Text>
)}
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Bodhi updates</DescriptionListTerm>
<DescriptionListDescription>
{data?.bodhi_update.length ? (
Expand Down

0 comments on commit 35dcd56

Please sign in to comment.