Fix golangci and update versions #76
Conversation
shibumi
force-pushed
the
fix-ci
branch
2 times, most recently
from
3bacf5c to
16884d7
Compare
|
package-url/purl-spec@c5681ae introduced breakage for our Go implementation or it's something we have to fix in this project to comply with the spec. |
shibumi
force-pushed
the
fix-ci
branch
4 times, most recently
from
fbad0e2 to
e791fd5
Compare
|
@sschuberth Can you approve this PR? It fixes the broken golangci and unblocks: #73 Also, I had to pin the test suite file. Looks like the upstream spec changed OR the packageurl-go version has a spec-drift. |
Sorry @shibumi, I was asked by @pombredanne to not do any "drive by" reviews anymore. As I'm unsure whether that only applies to the purl-spec project itself, or also to projects for implementations like this, I'll refrain from a review / approval until this is clarified. |
|
@sschuberth no problem :) @pombredanne do you know someone else who would be willing to maintain this project together with me? I need someone who can review PRs |
|
@sschuberth I am sure that @pombredanne only meant the specification repository, because that one is VERY important (lot's of projects are depending on it and it's our source of truth). I really see no problem in approving this PR, here :) Especially, because @pombredanne seems to be very inactive :/ @stevespringett, @johnmhoran, @iamwillbar, @jkowalleck, sorry for CC'ing you all. Can maybe one of you approve this PR here or can you appoint a second owner for this repository? Currently, all PRs are blocked and we should really fix these CI bugs ASAP. If you need a good candidate, I can maybe find someone from the open source software supply chain security community. |
The newest test-suite have new npm tests that were not yet implemented in packageurl-go. We will have to add the missing implementation first. This commit attempts to unblock all CI runs and unblock development.
Certain linters got deprecated in newer golangci-lint versions. We have to remove those linters from the list to avoid a blocking linter.
This commit updates several versions in our CI file.
Pull Request Test Coverage Report for Build 12339359460Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 12339359460Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 12339359460Details
💛 - Coveralls |
|
@sschuberth or @jkowalleck feel free to give it another review :) |
We have to unblock development by fixing Github Actions. In this PR, I changed the following: