Allow npm names to be case sensitive #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes absolutely sense. If we don't allow this, we will have no way to distinguish between older npm packages. NPM is really a mess.. LGTM |
|
@PFCM can you retrigger a CI run via: |
PFCM
force-pushed
the
npm-case-sensitive
branch
from
d122abd to
18ec00b
Compare
shibumi
force-pushed
the
npm-case-sensitive
branch
from
18ec00b to
680f68c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package names on npm have not always been forced to lower case, it is only enforced for new packages (see https://docs.npmjs.com/cli/v10/configuring-npm/package-json).
There are a number of cases where there are two distinct packages that differ only in casing, such as (borrowing from package-url/packageurl-java#38):
https://www.npmjs.com/package/Base64/v/1.0.0
https://www.npmjs.com/package/base64/v/1.0.0
Notably the Java implementation already does this (PR linked above), this discrepancy is certainly unfortunate.