Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation issues for PHP CS Fixer #38

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

ttomdewit
Copy link
Contributor

Summary

As per #37 we caught some deprecations in PHP CS Fixer, this PR aims to solve them.

Explanation

Ran the following commands:

  1. docker run --rm -v "$(pwd):/app" -w /app composer:2 install
  2. docker run --rm -v "$(pwd):/app" -w /app composer:2 fix
  3. docker run --rm -v "$(pwd):/app" -w /app composer:2 type
  4. docker run --rm -v "$(pwd):/app" -w /app composer:2 test

All were fine.

Checklist

  • I have provided a summary and an explanation
  • I have reviewed the PR myself and left comments to provide context
  • I have covered the changes with tests as appropriate - N/A
  • I have made sure static analysis and other checks are successful

@ttomdewit ttomdewit mentioned this pull request Nov 29, 2023
4 tasks
Copy link
Owner

@osteel osteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the maintenance tasks for me! Love it haha

@osteel osteel merged commit 420c26a into osteel:main Nov 30, 2023
8 checks passed
@ttomdewit ttomdewit deleted the update-cs-fixer-deprecations branch November 30, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants