Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.3 to testing matrix #39

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

ttomdewit
Copy link
Contributor

Summary

Since 8.3 is released I figured I'd add it to the testing matrix.

Explanation

Ran the following commands:

  1. docker run --rm -v "$(pwd):/app" -w /app php:8.3-fpm-alpine ./vendor/bin/php-cs-fixer fix -v
  2. docker run --rm -v "$(pwd):/app" -w /app php:8.3-fpm-alpine ./vendor/bin/phpunit
  3. docker run --rm -v "$(pwd):/app" -w /app php:8.3-fpm-alpine ./vendor/bin/phpstan

All against 8.3 runtime, no errors (aside from PHP CS Fixer deprecations since #38 isn't merged yet).

Checklist

  • I have provided a summary and an explanation
  • I have reviewed the PR myself and left comments to provide context
  • I have covered the changes with tests as appropriate - N/A
  • I have made sure static analysis and other checks are successful

Copy link
Owner

@osteel osteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@osteel osteel merged commit 276f7fa into osteel:main Nov 30, 2023
10 checks passed
@ttomdewit ttomdewit deleted the add-php-83-to-actions-matrix branch November 30, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants