Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony 7 support #37

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Add Symfony 7 support #37

merged 1 commit into from
Nov 29, 2023

Conversation

ttomdewit
Copy link
Contributor

@ttomdewit ttomdewit commented Nov 29, 2023

Add ^7.0 version constraint to Symfony Cache and Symfony HTTP foundation packages.

Summary

Simply extending the version constraint in composer.json.

Explanation

I need to see if I can extend the Github Actions if required.

Checklist

  • I have provided a summary and an explanation
  • I have reviewed the PR myself and left comments to provide context
  • I have covered the changes with tests as appropriate - N/A
  • I have made sure static analysis and other checks are successful

@ttomdewit
Copy link
Contributor Author

As far as I can tell from Github Actions YAML definition I do not need to touch it to address the ^7.0 constraint.

Add ^7.0 version constraint to Symfony Cache and Symfony HTTP foundation packages, plus the PSR HTTP message bridge.
@ttomdewit
Copy link
Contributor Author

I ran all composer scripts as per CONTRIBUTING:

  1. docker run --rm -v "$(pwd):/app" -w /app composer:2 install
  2. docker run --rm -v "$(pwd):/app" -w /app composer:2 fix
  3. docker run --rm -v "$(pwd):/app" -w /app composer:2 type
  4. docker run --rm -v "$(pwd):/app" -w /app composer:2 test

During the composer fix run some deprecations were made visible which I thought I'd share:

Detected deprecations in use:
- Rule "function_typehint_space" is deprecated. Use "type_declaration_spaces" instead.
- Rule "native_function_type_declaration_casing" is deprecated. Use "native_type_declaration_casing" instead.
- Rule "no_unneeded_curly_braces" is deprecated. Use "no_unneeded_braces" instead.

@ttomdewit ttomdewit marked this pull request as ready for review November 29, 2023 14:26
@osteel
Copy link
Owner

osteel commented Nov 29, 2023

Thanks for your contribution @ttomdewit!

I need to check why symfony/psr-http-message-bridge was set to version ^2.0.1 so far but in any case that's not an issue with this PR.

Thanks for pointing out the deprecations as well, will have a look

@osteel osteel merged commit 6011952 into osteel:main Nov 29, 2023
8 checks passed
@ttomdewit ttomdewit deleted the patch-1 branch November 29, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants