add reserved public ip #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyder
requested changes
Sep 10, 2021
hyder
previously approved these changes
Sep 14, 2021
2 tasks
hyder
reviewed
Sep 20, 2021
hyder
reviewed
Sep 20, 2021
hyder
reviewed
Sep 20, 2021
hyder
reviewed
Sep 20, 2021
hyder
reviewed
Sep 20, 2021
var.assign_public_ip becomes deprecated var.public_ip and var.public_ip_display_name are added to control this new resource var.public_ip accept a string with value NONE, RESERVED or EPHEMERAL. each keyword does what it says. fix oracle-terraform-modules#55
- fix assign_public_ip test condition - rename terraform resources from <this> to more meaningful name
kral2
force-pushed
the
55_add_reserved_public_ip
branch
from
6ec0d5a
to
53db5b9
Compare
hyder
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature description
This feature allow the module user to provision an instance with a reserved public IP.
The user still have the possibility to provision an instance without a public IP or with an ephemeral public IP.
The argument
assign_public_ipfrom thecreate_vnic_detailsblock onoci_core_instanceis not used anymore, as it do not allow assigning a reserved public IP.New resources
oci_core_public_ipControl variable
var.public_ipas string with the following accepted values: NONE, RESERVED or EPHEMERALvar.public_ip_display_nameas string, default to instance's display name