Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reserved public ip #71

Merged
merged 4 commits into from
Sep 20, 2021
Merged

add reserved public ip #71

merged 4 commits into from
Sep 20, 2021

Commits on Sep 20, 2021

  1. feat: initialize work on issue oracle-terraform-modules#55

    @kral2
    kral2 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    2b814a1 View commit details
    Browse the repository at this point in the history

  2. feat: add reserved IP support 

    var.assign_public_ip becomes deprecated
var.public_ip and var.public_ip_display_name are added to control this new resource

var.public_ip accept a string with value NONE, RESERVED or EPHEMERAL. each keyword does what it says.

fix oracle-terraform-modules#55
    @kral2
    kral2 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    ad165fa View commit details
    Browse the repository at this point in the history

  3. fix(reserved IP): add feedback from PR#71 review 

    - fix assign_public_ip test condition
- rename terraform resources from <this> to more meaningful name
    @kral2
    kral2 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    473e1e5 View commit details
    Browse the repository at this point in the history

  4. fix(docs): minor typo detected during PR review

    @kral2
    kral2 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    53db5b9 View commit details
    Browse the repository at this point in the history