Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support benchmark history summary v2.1 #3312

Merged
merged 15 commits into from
Apr 17, 2024
Merged

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Apr 12, 2024

Summary

image
image

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added TEST Any changes in tests BUILD labels Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.20%. Comparing base (6cce900) to head (f01b3c6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3312   +/-   ##
========================================
  Coverage    77.20%   77.20%           
========================================
  Files          198      198           
  Lines        16966    16966           
========================================
+ Hits         13098    13099    +1     
+ Misses        3868     3867    -1     
Flag Coverage Δ
py310 77.20% <ø> (+<0.01%) ⬆️
py311 77.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chuneuny-emily
chuneuny-emily previously approved these changes Apr 15, 2024
harimkang
harimkang previously approved these changes Apr 15, 2024
vinnamkim
vinnamkim previously approved these changes Apr 15, 2024
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection for this PR but I hope that we have a web UI (dashboard for this functionality), not just a Jupyter notebook in the future.

@goodsong81 goodsong81 dismissed stale reviews from vinnamkim, harimkang, and chuneuny-emily via c5d5f95 April 15, 2024 23:35
@goodsong81 goodsong81 marked this pull request as draft April 16, 2024 04:07
@github-actions github-actions bot added the DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM label Apr 16, 2024
@goodsong81 goodsong81 marked this pull request as ready for review April 17, 2024 01:57
@goodsong81 goodsong81 enabled auto-merge (squash) April 17, 2024 02:15
@goodsong81 goodsong81 merged commit cd03d83 into develop Apr 17, 2024
15 checks passed
@goodsong81 goodsong81 deleted the test/benchmark-history-v21 branch April 17, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants