-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replaces dashboard tab docs with link to openedx-aspects docs #515
Conversation
Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@bmtcril @Ian2012 I've replaced the markdown on the Instructor Dashboard tabs with a "Reference" link to the docs added by openedx/openedx-aspects#100. What do you think? Any tweaks? Once we're happy with it, I'll do the same to the Operator Dashboard tabs. |
I think we need a way to turn the links off entirely, and maybe some light help text should remain explaining what filters are required until we can fix that bug. I'm not sure how useful a configurable root url is if we have fixed paths appended to it, but I definitely don't want to have a per-chart setting either. Maybe the reference link is just at the dashboard level? 🤔 |
Help page markdown is configurable via ASPECTS_HELP_MARKDOWN. Also reinstates filter usage help on the other tabs.
Ok, how about a Help tab for each Dashboard instead (see updated image above)?
2d931f8 makes the content of that tab configurable in case institutions have their own links they want to use. It also allows the Help tab to be omitted by setting I'm also happy to change this to hard-coded Help text and an on/off flag if you prefer.
Sure, I've reinstated the help text about using filters. A workaround for this issue could be to set "select first filter value by default" for the required filters: |
...es/aspects/build/aspects-superset/openedx-assets/assets/dashboards/Instructor_Dashboard.yaml
Show resolved
Hide resolved
@crathbun428 may have some more thoughts but I think this is a good start. I'd say that we can probably have a "dashboards" landing page in the docs so they don't get dumped into the whole technical internals of the system, but that can be a follow on. Sadly "Select first filters by default" is buggy right now (it doesn't correctly clear / update based on the parent values, sometimes showing things like courses and problems that the user doesn't have access to). I'm working on a funded contribution that may including fixing it. |
and fix formatting errors.
* Uses different variables for the Instructor help markdown vs the Operator help markdown * Fixes YAML formatting that was breaking translations
Thank you for your comments @bmtcril & @crathbun428 ! How's it looking now?
I've linked to the specific reference page for each dashboard, see a11a0e0. These pages will be populated by openedx/openedx-aspects#100.
Oo, I'd love a chance to contribute to Superset! Will keep an eye out. |
@pomegranited - This looks good to me! (FYI - @bmtcril) |
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Moves the lengthy text descriptions out of the Dashboards and Charts and replaces them with deep links into the openedx-aspects reference documentation.
The Help markdown is configurable for each of the Operator and Instructor Dashboards, or the Help tab(s) may be omitted entirely by setting:
Screenshots
References
ref #169
Related to openedx/openedx-aspects#100