Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shortened course key on Operator Course charts #525

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

pomegranited
Copy link
Contributor

Description

Adds a computed course_key_short field to the xapi_events_all_parsed dataset, which strips the course-v1: prefix off of the beginning of the course_key.

Modifies the charts under the Operator > Courses tab to use course_key_short instead of course_key as the groupby/label.

Also re-adds the "Events per Course" chart to the Operator tab -- it must have gotten removed accidentally by #515?

Screenshots

operator_courses_charts

Related information

Closes #245

to the xapi_events_all_parsed dataset.

Use this field as the "group by" on the "Events per course" and
"Most active courses per day" charts.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 23, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Comment on lines +52 to +63
- advanced_data_type: null
column_name: course_key_short
description: "Course key without the course-v1: prefix"
expression: "splitByChar(':', splitByChar('/', course_id)[-1])[-1]"
extra: {}
filterable: true
groupby: true
is_active: true
is_dttm: false
python_date_format: null
type: null
verbose_name: course_key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmtcril Do you think we need to add the short_course_key to the table or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ian2012 I can add this (and course_key) as a proper table field if you'd prefer? I left this as a computed field because course_key is.

Copy link
Contributor

@Ian2012 Ian2012 Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, let's leave it as it is. Optimizations can be added later

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Nov 23, 2023
@Ian2012 Ian2012 merged commit c0aa93e into main Nov 29, 2023
6 checks passed
@Ian2012 Ian2012 deleted the jill/course_key_short branch November 29, 2023 17:05
@openedx-webhooks
Copy link

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Feat: Operator Dashboard Events per course course names
4 participants