-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shortened course key on Operator Course charts #525
Conversation
to the xapi_events_all_parsed dataset. Use this field as the "group by" on the "Events per course" and "Most active courses per day" charts.
Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
- advanced_data_type: null | ||
column_name: course_key_short | ||
description: "Course key without the course-v1: prefix" | ||
expression: "splitByChar(':', splitByChar('/', course_id)[-1])[-1]" | ||
extra: {} | ||
filterable: true | ||
groupby: true | ||
is_active: true | ||
is_dttm: false | ||
python_date_format: null | ||
type: null | ||
verbose_name: course_key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmtcril Do you think we need to add the short_course_key
to the table or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ian2012 I can add this (and course_key
) as a proper table field if you'd prefer? I left this as a computed field because course_key
is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, let's leave it as it is. Optimizations can be added later
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Adds a computed
course_key_short
field to thexapi_events_all_parsed
dataset, which strips thecourse-v1:
prefix off of the beginning of thecourse_key
.Modifies the charts under the Operator > Courses tab to use
course_key_short
instead ofcourse_key
as the groupby/label.Also re-adds the "Events per Course" chart to the Operator tab -- it must have gotten removed accidentally by #515?
Screenshots
Related information
Closes #245