Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Problem types added as filterable attribute [FC-0059] #35242

Merged
merged 4 commits into from
Aug 27, 2024
Merged

feat: Problem types added as filterable attribute [FC-0059] #35242

merged 4 commits into from
Aug 27, 2024

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Aug 7, 2024 •
edited
Loading

Description

Adds the capa problem types as filterable attribute on meilisearch index.

Supporting information

Testing instructions

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 7, 2024 •
edited
Loading

Thanks for the pull request, @ChrisChV!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 7, 2024
@ChrisChV ChrisChV changed the title feat: Problem types added as filterable attribute [FC-0059] feat: Problem types added as filterable attribute Aug 7, 2024
@ChrisChV ChrisChV marked this pull request as draft August 7, 2024 03:45
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Aug 12, 2024
@ChrisChV ChrisChV marked this pull request as ready for review August 15, 2024 01:09
@ChrisChV ChrisChV changed the title [FC-0059] feat: Problem types added as filterable attribute feat: Problem types added as filterable attribute [FC-0059] Aug 15, 2024
@ChrisChV ChrisChV mentioned this pull request Aug 15, 2024
Merged
navinkarkera
navinkarkera approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV 👍

pomegranited
pomegranited approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV 👍 This fix works exactly as described. One suggestion, but doesn't have to block merging if you disagree.

openedx/core/djangoapps/content/search/api.py Outdated Show resolved Hide resolved
@bradenmacdonald
Copy link
Contributor

@ChrisChV This looks ready to merge - please go ahead and merge it, unless I'm missing something :)

To do so:

  • Make sure you're within the merge timing window
  • Announce on Slack #cc-edx-platform that you'll merge this PR within 30 min or sooner if acknowledged (include a link)
  • Hit merge after 30 min

@ChrisChV
Copy link
Contributor Author

This looks ready to merge - please go ahead and merge it, unless I'm missing something :)

Thanks! I will merge it tomorrow morning :)

@ChrisChV ChrisChV merged commit 2e77e65 into openedx:master Aug 27, 2024
49 checks passed
@ChrisChV ChrisChV deleted the chris/FAL-3781-update-index-problem-types branch August 27, 2024 16:43
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

rediris pushed a commit to gymnasium/edx-platform that referenced this pull request Aug 27, 2024
@ChrisChV @rediris
feat: Problem types added as filterable attribute [FC-0059] (openedx#…
15bfe59 
…35242)
@ormsbee ormsbee mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navinkarkera navinkarkera navinkarkera approved these changes

@pomegranited pomegranited pomegranited approved these changes

Assignees
No one assigned
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ChrisChV @openedx-webhooks @bradenmacdonald @edx-pipeline-bot @pomegranited @navinkarkera @mphilbrick211