EVPN Multi Home Support #2084

JaiOCP · 2024-10-01T20:52:39Z

Host may be reachable via multiple VTEPs in the EVPN topology. In this case load balancing need to happen across VTEPs.

This is achieved using a new bridge port type SAI_BRIDGE_PORT_TYPE_BRIDGE_PORT_NEXT_HOP_GROUP that is going to use SAI_BRIDGE_PORT_ATTR_BRIDGE_PORT_NEXT_HOP_GROUP_ID for nexthop selection. Nexthop wll be the one of the available VTEP tunnels.

There can be an associated protection NHG configured SAI_BRIDGE_PORT_ATTR_BRIDGE_PORT_PROTECTION_NEXT_HOP_GROUP_ID, as a backup path in case the bridge port goes down.

This PR is open in lieu of
#2058

Signed-off-by: JaiOCP <[email protected]>

1. saibridge.h - Added SWITCHOVER attribute to bridgeport to trigger the switchover to/from the configured nexthopgroup 2. saivlan.h - Added BUM and UCAST Tx/Rx blocks - This is to support DF and SingleActive per vlan per port. Signed-off-by: Rajesh Sankaran <[email protected]>

inc/saibridge.h

Signed-off-by: Rajesh Sankaran <[email protected]>

ashutosh-agrawal · 2024-10-25T16:18:25Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+    - SAI_OBJECT_TYPE_ISOLATION_GROUP_MEMBER isogrp_mbr_oid_31 corresponding to isogrp_oid_3+bp_lag_oid_2 ( Traffic from VTEP-3 will be dropped on LAG-2 )
+    - SAI_OBJECT_TYPE_ISOLATION_GROUP_MEMBER isogrp_mbr_oid_41 corresponding to isogrp_oid_4+bp_lag_oid_1 ( Traffic from VTEP-4 will be dropped on LAG-1 )
+    - SAI_OBJECT_TYPE_ISOLATION_GROUP_MEMBER isogrp_mbr_oid_42 corresponding to isogrp_oid_4+bp_lag_oid_2 ( Traffic from VTEP-4 will be dropped on LAG-2 )
+


Please double check the naming of isogrp_mbr_oid. I think the first two can be renamed to isogrp_mbr_oid_22 and isogrp_mbr_oid_32 respectively.
nit: swap lines 3 and 4, so 3 lines for LAG-2 are together.

ashutosh-agrawal

LGTM

rajkumar38 · 2024-10-28T04:24:37Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+            vector<sai_attribute_t> attrs;
+
+            attr.id = SAI_FDB_ENTRY_ATTR_TYPE;
+            attr.value.s32 = SAI_FDB_ENTRY_TYPE_DYNAMIC;


This should be or TYPE STATIC ?

Yes it should be STATIC. Changed the doc.

rajkumar38 · 2024-10-28T04:27:19Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+            attr.value.oid = bp_nh_grp_1_oid;
+            attrs.push_back(attr);
+
+            attr.id = SAI_FDB_ENTRY_ATTR_ALLOW_MAC_MOVE;


Does this operation have any relation with saihost "SAI_HOSTIF_TRAP_TYPE_STATIC_FDB_MOVE". Default command is set to "drop". Does application need to configure explicit trap object with action "forward" ?

Given that ALLOW_MAC_MOVE is set to true there will be no need to
trap/drop the packets.

rajkumar38 · 2024-10-28T04:37:17Z

inc/saivlan.h

+     * @brief Indicates if the bridge port is set to drop the broadcast, unknown unicast and multicast traffic
+     *
+     * When set to true, ingress BUM traffic will be dropped
+     * Valid only when the SAI_VLAN_MEMBER_ATTR_BRIDGE_PORT_ID is of type PORT.


For these new attributes, can we indicate the conditions using "@Validonly" flag ?

SAI_VLAN_MEMBER_ATTR_BRIDGE_PORT_ID is an oid. So I am not clear how one can formalise this in a @validonly statement.

Signed-off-by: Rajesh Sankaran <[email protected]>

helloanandhi · 2024-11-04T05:53:40Z

inc/saibridge.h

@@ -85,6 +85,8 @@ typedef enum _sai_bridge_port_type_t
    /** Bridge tunnel port */
    SAI_BRIDGE_PORT_TYPE_TUNNEL,

+    /** Bridge port next hop group */
+    SAI_BRIDGE_PORT_TYPE_BRIDGE_PORT_NEXT_HOP_GROUP,


Can we have this named as SAI_BRIDGE_PORT_TYPE_NEXT_HOP_GROUP ?

helloanandhi · 2024-11-04T05:55:07Z

inc/saibridge.h

+     * @objects SAI_OBJECT_TYPE_NEXT_HOP_GROUP
+     * @condition SAI_BRIDGE_PORT_ATTR_TYPE == SAI_BRIDGE_PORT_TYPE_BRIDGE_PORT_NEXT_HOP_GROUP
+     */
+    SAI_BRIDGE_PORT_ATTR_BRIDGE_PORT_NEXT_HOP_GROUP_ID,


Same as above comment, can we name it as SAI_BRIDGE_PORT_ATTR_NEXT_HOP_GROUP_ID ?

helloanandhi · 2024-11-04T06:32:02Z

inc/saivlan.h

+     *
+     * When set to true, egress BUM traffic will be dropped
+     * Valid only when the SAI_VLAN_MEMBER_ATTR_BRIDGE_PORT_ID is of type PORT.
+     * Valid only for .1Q bridge ports.


Can the comment be made explicit and state it as below to include both port and lag ?

Valid only when the SAI_VLAN_MEMBER_ATTR_BRIDGE_PORT_ID is of type SAI_BRIDGE_PORT_TYPE_PORT

helloanandhi · 2024-11-04T06:45:59Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+
+  - Tunnels of peer mode P2P are only considered here. The isolation group object is used to achieve the split horizon functionality.
+  - There is no change to the Isolation group and group member definition.
+  - Bridgeport of type TUNNEL will also now have the isolation group attribute set.


Can we make the comment more explicit, stating only 'SAI_ISOLATION_GROUP_TYPE_BRIDGE_PORT' is applicable to realize split horizon filtering - with applicable bridge port types - SAI_BRIDGE_PORT_TYPE_PORT and SAI_BRIDGE_PORT_TYPE_TUNNEL

helloanandhi · 2024-11-04T06:48:07Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+     * @allownull true
+     * @default SAI_NULL_OBJECT_ID
+     */
+    SAI_BRIDGE_PORT_ATTR_BRIDGE_PORT_PROTECTION_NEXT_HOP_GROUP_ID,


Can we avoid repeating 'BRIDGE_PORT' in the attribute names ?

helloanandhi · 2024-11-04T06:51:16Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+
+### 3.2.4 Fast Failover support
+
+A new Bridge port attribute (for type PORT) is introduced to specify the protection nexthop group ID.


Please be explicit and use 'SAI_BRIDGE_PORT_TYPE_PORT' when you say PORT. As all these cases are applicable to port and lag.

helloanandhi · 2024-11-04T06:53:51Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+     *
+     * @type sai_object_id_t
+     * @flags CREATE_AND_SET
+     * @objects SAI_OBJECT_TYPE_NEXT_HOP_GROUP


Should the next hop group type be explicitly stated as SAI_NEXT_HOP_GROUP_TYPE_PROTECTION ?

skumar041 · 2024-11-04T07:52:03Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+     * @type bool
+     * @flags CREATE_AND_SET
+     * @default false
+     * @validonly SAI_BRIDGE_PORT_ATTR_TYPE == SAI_BRIDGE_PORT_TYPE_PORT or SAI_BRIDGE_PORT_ATTR_TYPE == SAI_BRIDGE_PORT_TYPE_SUB_PORT or SAI_BRIDGE_PORT_ATTR_TYPE == SAI_BRIDGE_PORT_TYPE_TUNNEL


Do we need bridge port of type "SAI_BRIDGE_PORT_TYPE_TUNNEL" in DF election ? Any use case?
It would be helpful if we can extend "4.3 DF workflow" with bridge port type as SAI_BRIDGE_PORT_TYPE_TUNNEL.

skumar041 · 2024-11-04T08:07:10Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+### 3.2.5 Single Active Redundancy Mode support
+
+Single Active redundancy mode requires unicast and BUM traffic to be dropped in the ingress and egress directions
+on the client port.


we shall use "multi-homed host/server" or "Multihomed ES port" instead of client, applicable for all places wherever client port is being used in this document

skumar041 · 2024-11-04T08:26:14Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+     * @flags MANDATORY_ON_CREATE | CREATE_ONLY
+     * @condition SAI_NEXT_HOP_ATTR_TYPE == SAI_NEXT_HOP_TYPE_IP or SAI_NEXT_HOP_ATTR_TYPE == SAI_NEXT_HOP_TYPE_MPLS or SAI_NEXT_HOP_ATTR_TYPE == SAI_NEXT_HOP_TYPE_TUNNEL_ENCAP or SAI_NEXT_HOP_ATTR_TYPE == SAI_NEXT_HOP_TYPE_BRIDGE_PORT
+     */
+    SAI_NEXT_HOP_ATTR_IP,


Do we need attr SAI_NEXT_HOP_ATTR_IP for SAI_NEXT_HOP_TYPE_BRIDGE_PORT? Is this for SAI_TUNNEL_PEER_MODE_P2MP?

if yes, please mention this under @brief .

skumar041 · 2024-11-04T08:39:57Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+    nhg_attr.value.s32 = SAI_NEXT_HOP_GROUP_TYPE_BRIDGE_PORT;
+    nhg_attrs.push_back(nhg_attr);
+
+    sai_object_id_t next_hop_group_id;


we shall use "sai_object_id_t nh_grp_oid_1"

sathk-marvell · 2024-11-04T09:36:39Z

inc/saibridge.h

+     * @allownull true
+     * @default SAI_NULL_OBJECT_ID
+     */
+    SAI_BRIDGE_PORT_ATTR_BRIDGE_PORT_PROTECTION_NEXT_HOP_GROUP_ID,


Actually, instead of having the protectin at nexthop group level, having protection for each nexthop(NHG member) might helps.

Assume, VTEP-5, had a nexthop group with members VTEP-{1,2,3,4}. what will be the backup members for this NHG. instead VTEP-1, can be protected with one member from VTEP-{2,3,4} and same way, VTEP-2 can be protected with one of the VTEP from VTEP-{1,3,4}.
Generally, not all members in a give nexthop group will not go down, so under what condition, switchover to backup Nexthop group is Initiated. if backup NHG also constituted from same VTEP list{1,2,3,4} by skipping one member. how does NOS knowns which member will go down

helloanandhi · 2024-11-04T12:54:40Z

doc/tunnel/SAI-Proposal-EVPN-Multihoming.md

+        mem_attr[0].id = SAI_ISOLATION_GROUP_MEMBER_ATTR_ISOLATION_GROUP_ID;
+        mem_attr[0].value.oid = isogrp_oid_2;
+        mem_attr[1].id = SAI_ISOLATION_GROUP_MEMBER_ATTR_ISOLATION_OBJECT;
+        mem_attr[1].value.oid = bp_po_oid_2;


What is bp_po_oid_2 ? No other reference to this.

Can attaching the isolation group also be covered in the workflow.

kcudnik · 2024-11-04T15:32:25Z

please fix build errors, you will need to squash your commits and force push, since validator is checking each commit separately

JaiOCP and others added 3 commits September 30, 2024 13:55

EVPN Multihoming

b829235

Signed-off-by: JaiOCP <[email protected]>

EVPN Multi Homing

627c259

Signed-off-by: JaiOCP <[email protected]>

JaiOCP mentioned this pull request Oct 1, 2024

EVPN Multi Home Support #2058

Closed

kcudnik reviewed Oct 2, 2024

View reviewed changes

inc/saibridge.h Outdated Show resolved Hide resolved

Updated EVPN MH workflow document.

b34b664

Signed-off-by: Rajesh Sankaran <[email protected]>

tjchadaga added the reviewed PR is discussed in SAI Meeting label Oct 24, 2024

ashutosh-agrawal reviewed Oct 25, 2024

View reviewed changes

ashutosh-agrawal approved these changes Oct 25, 2024

View reviewed changes

rajkumar38 reviewed Oct 28, 2024

View reviewed changes

adyeung mentioned this pull request Oct 28, 2024

Merged EVPN VxLAN MH HLD from Cisco and BCM sonic-net/SONiC#1702

Open

srj102 and others added 5 commits October 30, 2024 03:00

Incorporated comments.

9778bc1

Signed-off-by: Rajesh Sankaran <[email protected]>

Merge branch 'master' into evpn-mh

3bc7b26

Fixed compilation errors due to merge

6f4111f

Signed-off-by: Rajesh Sankaran <[email protected]>

EVPN Multihoming Changes

39e1f61

Signed-off-by: Rajesh Sankaran <[email protected]>

EVPN Multihoming Changes

eff896f

Signed-off-by: Rajesh Sankaran <[email protected]>

helloanandhi reviewed Nov 4, 2024

View reviewed changes

skumar041 reviewed Nov 4, 2024

View reviewed changes

sathk-marvell reviewed Nov 4, 2024

View reviewed changes

helloanandhi reviewed Nov 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EVPN Multi Home Support #2084

EVPN Multi Home Support #2084

JaiOCP commented Oct 1, 2024

ashutosh-agrawal Oct 25, 2024

srj102 Oct 30, 2024

ashutosh-agrawal left a comment

rajkumar38 Oct 28, 2024

srj102 Oct 30, 2024

rajkumar38 Oct 28, 2024

srj102 Oct 30, 2024

rajkumar38 Oct 28, 2024

srj102 Oct 30, 2024

helloanandhi Nov 4, 2024

helloanandhi Nov 4, 2024

helloanandhi Nov 4, 2024

helloanandhi Nov 4, 2024

helloanandhi Nov 4, 2024

helloanandhi Nov 4, 2024

helloanandhi Nov 4, 2024

skumar041 Nov 4, 2024

skumar041 Nov 4, 2024 •

edited

Loading

skumar041 Nov 4, 2024 •

edited

Loading

skumar041 Nov 4, 2024

sathk-marvell Nov 4, 2024

helloanandhi Nov 4, 2024

helloanandhi Nov 4, 2024

kcudnik commented Nov 4, 2024


		### 3.2.4 Fast Failover support

		A new Bridge port attribute (for type PORT) is introduced to specify the protection nexthop group ID.

EVPN Multi Home Support #2084

Are you sure you want to change the base?

EVPN Multi Home Support #2084

Conversation

JaiOCP commented Oct 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashutosh-agrawal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skumar041 Nov 4, 2024 • edited Loading

Choose a reason for hiding this comment

skumar041 Nov 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kcudnik commented Nov 4, 2024

skumar041 Nov 4, 2024 •

edited

Loading

skumar041 Nov 4, 2024 •

edited

Loading