[WIP] Completely rebuild the app in QML and overhaul the codebase #36
Conversation
This commit will shred every speck of Jekyll out of the welcome app, replacing it with a nice QML interface. While I'm not going for a pixel-perfect recreation of the app, I'm trying to get a UI that looks mostly the same as the Jekyll version. As part of the rewrite, I'm overhauling the codebase to use best practices for modern Qt and open-source projects in general. This includes adding a .clang-format file to keep the code looking nice. Closes openSUSE#34
| @@ -1,5 +1,7 @@ | |||
| <RCC> | |||
| <qresource prefix="/"> | |||
| <file>main.qml</file> | |||
| <file>ThemedButton.qml</file> | |||
| <file>qtquickcontrols2.conf</file> | |||
| @@ -21,48 +33,63 @@ void Enabler::enableAutostart() | |||
| void Enabler::disableAutostart() | |||
| { | |||
| qDebug() << "disable autostart called"; | |||
| QFile::copy(":/desktop-file/org.opensuse.opensuse_welcome.desktop", QDir::homePath() + "/.config/autostart/org.opensuse.opensuse_welcome.desktop"); | |||
| QFile::copy(":/desktop-file/org.opensuse.opensuse_welcome.desktop", | |||
| QDir::homePath() + "/.config/autostart/org.opensuse.opensuse_welcome.desktop"); | |||
| qDebug() << QDir::homePath() + "/.config/autostart/org.opensuse.opensuse_welcome.desktop"; | |||
| } | |||
| bool Enabler::fileExists(QString path) | |||
There was a problem hiding this comment.
This can just be QFile::exists(path). The case that the path is a non-file shouldn't be relevant.
| qDebug() << "there isn't a file to disable, so it's enabled"; | ||
| return true; | ||
| } | ||
| } | ||
| void Enabler::toggle() { | ||
| void Enabler::toggle() | ||
| { | ||
| qDebug() << "checking if autostart is enabled"; |
There was a problem hiding this comment.
This can now be just setAutostart(!autostartEnabled())
| qtTranslator.load("qt_" + QLocale::system().name(), | ||
| QLibraryInfo::location(QLibraryInfo::TranslationsPath)); | ||
| app.installTranslator(&qtTranslator); | ||
| if (qtTranslator.load( |
There was a problem hiding this comment.
Loading Qt's translations shouldn't be necessary
| @@ -4,6 +4,6 @@ welcome = executable('opensuse-welcome', | |||
| welcome_sources, | |||
| processed_files, | |||
| include_directories : inc, | |||
| dependencies: qt5_dep, | |||
| dependencies: qt6_dep, | |||
|
I think this is the step in the right direction, I have some plans on making it look nicer, but it's better to start with having a more solid base for the time being |
|
@lkocman I have not put any work into this for a while as I've gotten busy with other things. I may be able to come back and work on it some more, though. Also, how imperative is it that we keep the exact look and feel intact? If we decided to go for more of a themed look (i.e. use regular QML theming to fit with the system theme more) and/or combined the rewrite with a redesign, it would probably help reduce the effort since we would't have to port every little detail over. |
|
I wouldn't worry about the exact theming, I might want to make the app look different in the future, but let's just get it rewritten first and we will think about how it will look after that |
This commit will shred every speck of Jekyll out of the welcome
app, replacing it with a nice QML interface. While I'm not going
for a pixel-perfect recreation of the app, I'm trying to get a
UI that looks mostly the same as the Jekyll version.
As part of the rewrite, I'm overhauling the codebase to use best
practices for modern Qt and open-source projects in general. This
includes adding a .clang-format file to keep the code looking nice.