Should this be ported away from a web view? #34
Comments
|
I can't see anything in the app blocking this at least. That could be done in conjunction with #35 since it's a major change. |
|
I actually am already working on the QML port, which involved porting to Qt 6. (Actually, it's more of a massive overhaul to the codebase to bring it in line with modern standards.) I'll push a draft PR with what I've got so far. |
|
@herzenschein: see #36. |
LorenDB
added a commit
to LorenDB/openSUSE-welcome
that referenced
this issue
Feb 28, 2024
This commit will shred every speck of Jekyll out of the welcome app, replacing it with a nice QML interface. While I'm not going for a pixel-perfect recreation of the app, I'm trying to get a UI that looks mostly the same as the Jekyll version. As part of the rewrite, I'm overhauling the codebase to use best practices for modern Qt and open-source projects in general. This includes adding a .clang-format file to keep the code looking nice. Closes openSUSE#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am surprised that this application is implemented as a web view inside a QML window. To me, this seems like a poor implementation, and I'd personally like to see it either embrace the webview (e.g. full Electron/Tauri mode) or (preferably) go full QML. This would result in both a lighter overall application and a cleaner, easier-to-interact-with codebase.
AFAICT, there is not really any major blocker to using QML to recreate the existing app, as it's just a page with a few buttons plus a few subpages of text, all of which is super easy to do in QML. I'd personally be happy to create a POC port to QML if nobody is opposed.
The text was updated successfully, but these errors were encountered: