Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle warnings #659

Merged
merged 5 commits into from
Jul 10, 2020
Merged

Gradle warnings #659

merged 5 commits into from
Jul 10, 2020

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Jul 9, 2020

The majority of remaining Gradle warnings is fixed.

Remaing warnings are mostly due to Playframework gradle plugin. See gradle/playframework#114

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for doing this

@@ -12,6 +12,7 @@ spotless {
scala {
scalafmt()
licenseHeaderFile rootProject.file('gradle/enforcement/spotless.license.java'), '(package|import|public)'
target 'src/**/*.scala'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

@@ -1,30 +1,20 @@
plugins {
id 'play'
id "org.gradle.playframework" version "0.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iNikem iNikem merged commit b77fb26 into open-telemetry:master Jul 10, 2020
mabdinur pushed a commit to mabdinur/opentelemetry-java-instrumentation that referenced this pull request Jul 10, 2020
* More gradle warnings fixes

* Disable javadoc where it is definitely not needed

* Polish
@iNikem iNikem deleted the gradle-warnings branch July 11, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants