Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated features in Gradle build scripts #351

Closed
iNikem opened this issue Apr 25, 2020 · 5 comments · Fixed by #2103
Closed

Fix deprecated features in Gradle build scripts #351

iNikem opened this issue Apr 25, 2020 · 5 comments · Fixed by #2103

Comments

@iNikem
Copy link
Contributor

iNikem commented Apr 25, 2020

Current gradle build scripts use a lot of deprecated features, that are expected to stop working in gradle's next major version. We should fix them.
@trask trask added good first issue Good for newcomers contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome labels Apr 25, 2020
@iNikem
Copy link
Contributor Author

iNikem commented Apr 27, 2020

I have tried to do this and failed :) I am not sure this is very good candidate for good firs issue. It requires the understanding of generated gradle tasks. And choosing between api and implementation may require understanding the purpose of gradle submodules. Which is not documented at.

@trask
Copy link
Member

trask commented Apr 27, 2020

Thanks for giving it a shot, and for your assessment! I will remove the good first issue tag.

@trask trask removed the good first issue Good for newcomers label Apr 27, 2020
@trask trask removed the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Jun 2, 2020
@iNikem iNikem mentioned this issue Jun 22, 2020
Merged
@trask
Copy link
Member

trask commented Jul 16, 2020

Mostly done, see #643, #653, #659, and some other earlier PRs too.

@iNikem @anuraaga do you want to keep this open? Once we remove all deprecated features, can we enable some kind of flag to fail the build if any creep back?

@iNikem
Copy link
Contributor Author

iNikem commented Jul 16, 2020

Yes and yes

@trask trask added contributor experience Something that we can do to improve the experience of contributors (especially new contributors) cleanup and removed contributor experience Something that we can do to improve the experience of contributors (especially new contributors) labels Jul 19, 2020
@iNikem iNikem mentioned this issue Jul 22, 2020
Closed
@vovencij
Copy link
Contributor

Some are fixed here: #2085

At the moment of writing I think there is only one Gradle deprecation warning left.

@iNikem iNikem mentioned this issue Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No more gradle warnings iNikem/opentelemetry-java-instrumentation
4 participants
@anuraaga @trask @vovencij @iNikem