(2/3) Use Cobra, Koanf, and Ozzo rather than urfave/cli #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #110 -- please review and merge first, and I will rebase this PR
Description of the change
Sorry, I know this is a huge PR! It would have been way more work to try and move to Cobra and Koanf separately. This PR attempts to make no functional changes, and only refactor to new libraries. The libraries in question:
Of course, I failed slightly at this -- I added Signal handling to the HTTP Server to shutdown gracefully when stopped.
Benefits
config
, config logic has been removed fromclient
.Possible drawbacks
It's just a big PR :-(
Applicable issues
Additional information