Add --backfill & --backfill-since-date options for Prowlarr. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtrox
force-pushed
the
prowlarr_backfill_options
branch
from
e1451a8 to
5a355e3
Compare
Signed-off-by: Russell Troxel <[email protected]>
rtrox
force-pushed
the
prowlarr_backfill_options
branch
from
5a355e3 to
e575eaf
Compare
|
Looks good, but we might want to update the README to reflect this change. |
Signed-off-by: Russell Troxel <[email protected]>
|
Good catch, updated. |
onedr0p
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** NOTE: depends on two prior PRs, review #114 and #115 first.**
Description of the change
Per title, creates some controls on how backfill is executed. If
--backfillis set and/or--backfill-since-dateis set, Prowlarr will backfill, starting from the beginning of time, or from the backfill date respectively.Note that this is a change from prior behavior,
enable-additional-metricsis no longer involved here. I think this is probably ok, breaking change wise, since the prior behavior hasn't yet seen a release.Benefits
Allows control over backfills to prevent timeouts when attempting to backfill.
Possible drawbacks
Using a date rather than a duration helps protect against broken metrics, but conceivably a user good change their backfill date, in which case, they would see an issue in prometheus where aggregation metrics (
increase(),rate(), etc) over the restart period may assume a jump in metrics which isn't actually present. This would require conscious effort, and only impacts that point in time.Applicable issues
Additional information