russian update, escaped quotes, %s simplification #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slavick I did some additional XML detailed regression checking which resulted in commit 73ab04f. This last commit fixed two discovered issues:
The escaped quotes ( So, with that, I think this pull request is ready to be put into a test build when you have time. |
|
@slavick And, one more thing... a minor Italian update did also get added. See: nutritionfactsorg/daily-dozen-localization#12 (comment) |
slavick
added a commit
that referenced
this pull request
Aug 14, 2022
* unified imperial, metric strings (removes need for %s) (#204) see #201 * Implement change to read full serving size strings instead of building them * russian update, escaped quotes, %s simplification (#205) * russian update * xml fixes: `\\'` to `\'`, `\ N` to `\n\n` * escaped double quotes `\"` * fixed "about_text_lines" mapping. also some misc update (fractions) * some Italian updates. French: l\\'application --> l\'application * Update versionCode and versionName * Remove redundant label * Add try/catch for exception that has been observed * Remove unpopular translations * Update strings * Change createWeightsIfDoesNotExist to return boolean (indicating weights saved) instead of the unused Weights object * Remove unused code * Revert "Remove unpopular translations" This reverts commit a6b9c9c. * Update strings * Update versionCode * Update Spanish translation * Update versionCode and versionName * Update Spanish (#206) Co-authored-by: --marc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@slavick This PR has several updates:
daily-dozen-localizationwhere the single quote should be escaped as\'when generating thestrings.xmlfiles.\"in the content.strings.xmlgeneration is a single line of code to change nutritionfactsorg/daily-dozen-localization@ea7ec85"\\\""in a Swift String literial becomes\"internally.%1$shave been replaced with a simplified%s. The thinking is:1$does not appear to be programmatically needed in the Java code.%sformatter can also work in the iOS Swift code.%1$sis not support in a Swift formatter string.%sis easer than%1$sfor translators to work with in the spreadsheet