Address review notes. #315

	name: nginx-otel-module-check
	run-name: ${{ github.actor }} is triggering pipeline
	on:
	push:
	workflow_dispatch:

	jobs:
	build-module:
	runs-on: ubuntu-latest
	steps:
	- name: Checkout repository
	uses: actions/checkout@v4
	- name: Install dependencies
	run: \|
	sudo apt-get update
	sudo apt-get install -y cmake libc-ares-dev libre2-dev
	- name: Checkout nginx
	uses: actions/checkout@v4
	with:
	repository: nginx/nginx
	path: nginx
	- name: Build nginx
	working-directory: nginx
	run: \|
	auto/configure --with-compat --with-debug --with-http_ssl_module \
	--with-http_v2_module --with-http_v3_module
	make -j $(nproc)
	- name: Create build directory
	run: mkdir build
	- name: Build module
	working-directory: build
	run: \|
	cmake -DNGX_OTEL_NGINX_BUILD_DIR=${GITHUB_WORKSPACE}/nginx/objs \
	-DNGX_OTEL_DEV=ON ${GITHUB_WORKSPACE}
	make -j $(nproc)
	- name: Download otelcol
	run: \|
Check failure on line 37 in .github/workflows/nginx-otel-module-check.yml View workflow run for this annotation GitHub Actions / .github/workflows/nginx-otel-module-check.yml Invalid workflow file `You have an error in your yaml syntax on line 37`
	curl -LO https://github.com/\
	open-telemetry/opentelemetry-collector-releases/releases/download/\
	v0.113.0/otelcol_0.113.0_linux_amd64.tar.gz
	tar -xzf otelcol_0.113.0_linux_amd64.tar.gz
	- name: Run tests
	working-directory: tests
	run: \|
	python -m venv venv
	source venv/bin/activate
	pip install -r requirements.txt
	TEST_NGINX_GLOBALS="load_module ${PWD}/../build/ngx_otel_module.so;" \
	pytest --log-cli-level=debug

Provide feedback