Address review notes.

nginxinc · Nov 18, 2024 · d798e13 · d798e13
1 parent 6e48263
commit d798e13
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/.github/workflows/nginx-otel-module-check.yml b/.github/workflows/nginx-otel-module-check.yml
@@ -34,19 +34,16 @@ jobs:
                 -DNGX_OTEL_DEV=ON ${GITHUB_WORKSPACE}
           make -j $(nproc)
       - name: Download otelcol
-        uses: robinraju/[email protected]
-        with:
-          repository: open-telemetry/opentelemetry-collector-releases
-          tag: v0.113.0
-          fileName: otelcol_0.113.0_linux_amd64.tar.gz
-          extract: true
+          run: |
+            curl -LO https://github.com/\
+            open-telemetry/opentelemetry-collector-releases/releases/download/\
+            v0.113.0/otelcol_0.113.0_linux_amd64.tar.gz
+            tar -xzf otelcol_0.113.0_linux_amd64.tar.gz
       - name: Run tests
         working-directory: tests
-        env:
-          TEST_NGINX_GLOBALS: |
-            load_module ${{ github.workspace }}/build/ngx_otel_module.so;
         run: |
           python -m venv venv
           source venv/bin/activate
           pip install -r requirements.txt
+          TEST_NGINX_GLOBALS="load_module ${PWD}/../build/ngx_otel_module.so;" \
           pytest --log-cli-level=debug