Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] Drop need of user folder #2640

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Nov 27, 2023

The versions are bound to the groupfolder and not the current user. So we can get the File object without the current user folder.
This helps in situations where no user is logged in, like background jobs.

Psalm errors already exist in stable28

@artonge artonge marked this pull request as draft November 27, 2023 15:39
@artonge artonge self-assigned this Nov 27, 2023
@artonge artonge added the 3. to review Items that need to be reviewed label Nov 27, 2023
@artonge artonge added 2. developing Items that are currently under development bug php Items related to PHP updates and code issues and removed 3. to review Items that need to be reviewed labels Dec 7, 2023
@luka-nextcloud

This comment was marked as outdated.

@Chartman123

This comment was marked as resolved.

@solracsf

This comment was marked as resolved.

@artonge artonge force-pushed the artonge/fix/drop_userfolder_need branch from fd276e2 to 398496e Compare December 13, 2023 15:39
@artonge artonge changed the base branch from master to stable28 December 13, 2023 15:45
@artonge artonge changed the title Drop need of user folder [stable28] Drop need of user folder Dec 13, 2023
@artonge artonge changed the base branch from stable28 to master December 13, 2023 15:47
@artonge artonge force-pushed the artonge/fix/drop_userfolder_need branch from 398496e to b18ab21 Compare December 13, 2023 15:51
@artonge artonge changed the base branch from master to stable28 December 13, 2023 15:51
@artonge artonge marked this pull request as ready for review December 13, 2023 15:52
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/fix/drop_userfolder_need branch from b18ab21 to 0158f02 Compare December 13, 2023 15:52
@artonge artonge added this to the Nextcloud 28 milestone Dec 13, 2023
@artonge artonge mentioned this pull request Dec 14, 2023
@solracsf
Copy link
Member

solracsf commented Dec 14, 2023

@artonge what about to previously check if the entity does not already exists?
Something like, L88:

if (!$this->groupVersionsMapper->exists($versionEntity) {
	$this->groupVersionsMapper->insert($versionEntity);
}

(or limited to file_id & timestamp instead checking the whole entity)
Couldn't it help with #2559 (comment) ?

@artonge
Copy link
Contributor Author

artonge commented Dec 14, 2023

artonge what about to previously check if the entity does not already exists?

It would hide the reason getVersionsForFileFromDB fails 🤔

@artonge artonge merged commit e5f5efd into stable28 Dec 14, 2023
15 of 16 checks passed
@artonge artonge deleted the artonge/fix/drop_userfolder_need branch December 14, 2023 16:40
@solracsf
Copy link
Member

Can this be backported to 27?

@artonge
Copy link
Contributor Author

artonge commented Dec 18, 2023

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Items that are currently under development bug php Items related to PHP updates and code issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants