Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty array if no user is found #2638

Closed
wants to merge 2 commits into from
Closed

Conversation

solracsf
Copy link
Member

Try to fix #2559
Assuming it's OK to return an empty array in this case.

@solracsf solracsf added the 3. to review Items that need to be reviewed label Nov 27, 2023
Signed-off-by: Git'Fellow <[email protected]>
@artonge
Copy link
Contributor

artonge commented Nov 27, 2023

I think a better fix would be to drop the need to find a user folder.
I drafted something here: #2640
But haven't had time to test it.

@solracsf
Copy link
Member Author

Makes perfectly sense 👍 Closing this one.

@solracsf solracsf closed this Nov 27, 2023
@solracsf solracsf deleted the returnEmptyArray branch November 27, 2023 15:42
@solracsf solracsf removed the request for review from artonge November 27, 2023 15:42
@solracsf solracsf removed the 3. to review Items that need to be reviewed label Nov 27, 2023
@artonge
Copy link
Contributor

artonge commented Nov 27, 2023

@solracsf do you experience the issue yourself? If so, I would ask you to test my solution once I properly tested it myself :).

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backends provided no user object / Duplicate entry for key 'gf_versions_uniq_index'
2 participants