Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove recorder from diagnostics test #196

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Remove recorder from diagnostics test #196

merged 2 commits into from
Oct 15, 2023

Commits on Oct 14, 2023

  1. Remove recorder from diagnostics test 

    We robustify this test by not relying on a bag recorder, but instead
have a subscriber within the same process as the test. Since we have the
messages available without extra effort, we use the chance to also check
the contents of the messages.
    @ahans
    ahans committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    6606fb5 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Address comments

    @ahans
    ahans committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    9f6bbdd View commit details
    Browse the repository at this point in the history