Remove recorder from diagnostics test #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahans
commented
Oct 14, 2023
ahans
commented
Oct 14, 2023
We robustify this test by not relying on a bag recorder, but instead have a subscriber within the same process as the test. Since we have the messages available without extra effort, we use the chance to also check the contents of the messages.
ahans
force-pushed
the
bugfix/ahans/diagnostics-test
branch
from
164cca6
to
6606fb5
Compare
mvukov
reviewed
Oct 15, 2023
|
Addressed comments. Please have another look! |
mvukov
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We robustify this test by not relying on a bag recorder, but instead have a subscriber within the same process as the test. Since we have the messages available without extra effort, we use the chance to also check the contents of the messages.
Fixes #195.