-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Fix charts not passing className to root element #13647
base: master
Are you sure you want to change the base?
[charts] Fix charts not passing className to root element #13647
Conversation
Deploy preview: https://deploy-preview-13647--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refs passed to ResponsiveChartContainer go to wrapper div instead of svg element. Breaking?
⚠️
Yes, this seems to be breaking change. Even if it's not the standard, their is some consistency by always passing the ref to the SVG component.
packages/x-charts-pro/src/ResponsiveChartContainerPro/ResponsiveChartContainerPro.tsx
Outdated
Show resolved
Hide resolved
I don't remember if we decided to do V8 or not 😅, should we wait to merge this?
I think if it is necessary to have it always on the SVG we could have a proper |
The v8 should be in 6 months
This would not fix the breaking change aspect. Someone using the
Is it the main reason to do the modification? |
I didn't mean it as a solution, but rather as a feature. If we want the user to always have access to the SVG directly, we can have a prop that does exactly that. Otherwise I think the My point of view is that if I have the topmost ref I can get any of the children elements I need, though I also see it being useful to have a ref directly to the SVG element. |
'mergeClassName', 'propsSpread', 'refForwarding', 'reactTestRenderer', 'rootClass'
ResponsiveChartContainer
go to wrapperdiv
instead ofsvg
element. Breaking?Gauge
andPieChart
componentsMediaQueryList
error on jsdomfixes #13292