Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] The parser of the describe conformance consider skip but not only config #42832

Open
alexfauquette opened this issue Jul 3, 2024 · 0 comments
Labels
scope: code-infra Specific to the core-infra product

Comments

@alexfauquette
Copy link
Member

alexfauquette commented Jul 3, 2024

Found while reviewing mui/mui-x#13647

If you use the describeConformance(..., () => ({ only: ['themeDefaultProps'})), all the attributes will be added to the API page instead of just the theme dfault props one.

THe reason is that the script filter the skipped test but do not take into consideration the only:

https://github.com/mui/material-ui/blob/master/packages/api-docs-builder/utils/parseTest.ts/#L164-L185

Solution can either be to remove only from describe conformance, or take only into consideration in the parsing

Search keywords:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

No branches or pull requests

1 participant