[material-ui][Rating] fix defaultLabelText a11y issue with undefine value input and hint #42810
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 1, 2024 15:16
aarongarciah
added
bug 🐛
aarongarciah
reviewed
Jul 1, 2024
Comment on lines
329
to
330
| const _value = value || 0; | ||
| return `${_value} Star${_value > 1 ? 's' : ''}`; |
There was a problem hiding this comment.
This would give us:
- ❌
null(or any falsy value) =>"0 Star"(it should be in plural) - ❌
0=>"0 Star"(it should be in plural) - ✅
1=>"1 Star" - ✅
2=>"2 Stars"
If we change it to this, we get better results:
Suggested change
| const _value = value || 0; | |
| return `${_value} Star${_value > 1 ? 's' : ''}`; | |
| return `${value || "0"} Star${value !== 1 ? 's' : ''}`; |
- ✅
null(or any falsy value) =>"0 Stars" - ✅
0=>"0 Stars" - ✅
1=>"1 Star" - ✅
2=>"2 Stars"
There was a problem hiding this comment.
Thanks @aarongarciah
LGTM, updated😎
Comment on lines
687
to
688
| * const _value = value || 0; | ||
| * return `${_value} Star${_value > 1 ? 's' : ''}`; |
There was a problem hiding this comment.
Modify this to match the previous comment in this file.
| it('can be labelled with getLabelText when non set value', () => { | ||
| render(<Rating readOnly />); | ||
|
|
||
| expect(screen.getByRole('img')).toHaveAccessibleName('0 Heart'); |
There was a problem hiding this comment.
It should be in plural.
Suggested change
| expect(screen.getByRole('img')).toHaveAccessibleName('0 Heart'); | |
| expect(screen.getByRole('img')).toHaveAccessibleName('0 Hearts'); |
aarongarciah
reviewed
Jul 4, 2024
| @@ -225,6 +225,12 @@ describe('<Rating />', () => { | |||
| expect(screen.getByRole('img')).toHaveAccessibleName('Stars: 2'); | |||
| }); | |||
|
|
|||
| it('can be labelled with getLabelText when non set value', () => { | |||
There was a problem hiding this comment.
This test title seems incorrect.
Suggested change
| it('can be labelled with getLabelText when non set value', () => { | |
| it('should have a correct label when no value is set', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when I use Rating readOnly mode, I found there is a issue with the aria-label by default
defaultLabelTextwhich will render like below
aria-label="null Hearts"