[material-ui][Rating] modify with default value

mui · Jul 4, 2024 · 9ff905c · 9ff905c
1 parent 1c140f9
commit 9ff905c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/mui-material/src/Rating/Rating.js b/packages/mui-material/src/Rating/Rating.js
@@ -326,8 +326,7 @@ const defaultIcon = <Star fontSize="inherit" />;
 const defaultEmptyIcon = <StarBorder fontSize="inherit" />;
 
 function defaultLabelText(value) {
-  const _value = value || 0;
-  return `${_value} Star${_value > 1 ? 's' : ''}`;
+  return `${value || '0'} Star${value !== 1 ? 's' : ''}`;
 }
 
 const Rating = React.forwardRef(function Rating(inProps, ref) {
@@ -684,8 +683,7 @@ Rating.propTypes /* remove-proptypes */ = {
    * @param {number} value The rating label's value to format.
    * @returns {string}
    * @default function defaultLabelText(value) {
-   *    const _value = value || 0;
-   *    return `${_value} Star${_value > 1 ? 's' : ''}`;
+   *    return `${value || "0"} Star${value !== 1 ? 's' : ''}`;
    * }
    */
   getLabelText: PropTypes.func,

diff --git a/packages/mui-material/src/Rating/Rating.test.js b/packages/mui-material/src/Rating/Rating.test.js
@@ -228,7 +228,7 @@ describe('<Rating />', () => {
     it('can be labelled with getLabelText when non set value', () => {
       render(<Rating readOnly />);
 
-      expect(screen.getByRole('img')).toHaveAccessibleName('0 Heart');
+      expect(screen.getByRole('img')).toHaveAccessibleName('0 Hearts');
     });
 
     it('should have readOnly class applied', () => {