Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 🚑 #385

Merged
merged 1 commit into from
Jul 9, 2024
Merged

🔧 🚑 #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion findmyorder/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""
FindMyOrder Config
"""

import os

from dynaconf import Dynaconf
Expand All @@ -18,10 +19,13 @@
os.path.join(ROOT, "default_settings.toml"),
"talky_settings.toml",
"settings.toml",
".secrets.toml" ".op.toml",
".secrets.toml",
".op.toml",
],
# Load the.env file
load_dotenv=True,
# merge=True,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Remove commented-out code if not needed.

If the 'merge=True' line is no longer needed, consider removing it to keep the codebase clean. If it is needed for future reference, it might be better to add a comment explaining why it is commented out.

Suggested change
# merge=True,
# The following line is commented out for future reference:
# merge=True,

merge_enabled=True,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Potential redundancy with 'merge' and 'merge_enabled'.

The new 'merge_enabled' parameter might be redundant if 'merge' was intended to serve the same purpose. Consider consolidating these settings to avoid confusion.

# Set the environments to True
environments=True,
# Set the default environment
Expand Down