🔧 🚑

[mraniki]

Summary by Sourcery

This pull request enhances the configuration loading process by enabling the merging of configuration files and fixes a typo in the list of configuration files.

• Bug Fixes:
  • Fixed a typo in the list of configuration files by separating '.secrets.toml' and '.op.toml' into distinct entries.
• Enhancements:
  • Enabled merging of configuration files by setting 'merge_enabled' to True.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses a typo in the configuration file list and introduces a new configuration option 'merge_enabled' set to True. The old 'merge' option has been commented out.

File-Level Changes

Files	Changes
findmyorder/config.py	Corrected configuration file list and added a new 'merge_enabled' option.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @mraniki - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion: Remove commented-out code if not needed.

If the 'merge=True' line is no longer needed, consider removing it to keep the codebase clean. If it is needed for future reference, it might be better to add a comment explaining why it is commented out.

Suggested change

	# merge=True,
	# The following line is commented out for future reference:
	# merge=True,

[sourcery-ai]

issue: Potential redundancy with 'merge' and 'merge_enabled'.

The new 'merge_enabled' parameter might be redundant if 'merge' was intended to serve the same purpose. Consider consolidating these settings to avoid confusion.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b6f833a) to head (2d5c827).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #385   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          141       141           
=========================================
  Hits           141       141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.