-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔊 #383
Merged
🔊 #383
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -111,14 +111,14 @@ def _create_client(self, **kwargs): | |||||
library is not supported. | ||||||
|
||||||
""" | ||||||
# library = kwargs.get("parser_library", "standard") | ||||||
library = ( | ||||||
kwargs.get("library") | ||||||
or kwargs.get("platform") | ||||||
or kwargs.get("protocol") | ||||||
or kwargs.get("parser_library") | ||||||
or "standard" | ||||||
) | ||||||
logger.debug("Library: {}", library) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: Use f-string for logging Consider using an f-string for the logging statement to maintain consistency and readability. For example:
Suggested change
|
||||||
cls = self.client_classes.get((f"{library.capitalize()}Handler")) | ||||||
return None if cls is None else cls(**kwargs) | ||||||
|
||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Remove commented-out code
Consider removing the commented-out line entirely if it is no longer needed. Keeping commented-out code can clutter the codebase and reduce readability.