Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔊 #383

Merged
merged 1 commit into from
Jul 9, 2024
Merged

🔊 #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion findmyorder/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,14 @@ def _create_client(self, **kwargs):
library is not supported.

"""
# library = kwargs.get("parser_library", "standard")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Remove commented-out code

Consider removing the commented-out line entirely if it is no longer needed. Keeping commented-out code can clutter the codebase and reduce readability.

Suggested change
# library = kwargs.get("parser_library", "standard")
library is not supported.
"""
library = (
kwargs.get("library")

library = (
kwargs.get("library")
or kwargs.get("platform")
or kwargs.get("protocol")
or kwargs.get("parser_library")
or "standard"
)
logger.debug("Library: {}", library)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Use f-string for logging

Consider using an f-string for the logging statement to maintain consistency and readability. For example: logger.debug(f"Library: {library}").

Suggested change
logger.debug("Library: {}", library)
logger.debug(f"Library: {library}")

cls = self.client_classes.get((f"{library.capitalize()}Handler"))
return None if cls is None else cls(**kwargs)

Expand Down