-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feature: adding action_identifier for each client in get_info #382
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -153,7 +153,10 @@ async def get_info(self): | |||||||||||
|
||||||||||||
""" | ||||||||||||
version_info = f"ℹ️ {type(self).__name__} {__version__}\n" | ||||||||||||
client_info = "".join(f"🔎 {client.name}\n" for client in self.clients) | ||||||||||||
client_info = "".join( | ||||||||||||
f"🔎 {client.name}\n🔠 {client.action_identifier}" | ||||||||||||
for client in self.clients | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion (performance): Consider the performance impact of the join operation inside a generator expression. While the current implementation is likely efficient for a small number of clients, if
Suggested change
|
||||||||||||
) | ||||||||||||
return version_info + client_info.strip() | ||||||||||||
|
||||||||||||
async def search(self, message: str) -> bool: | ||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider handling cases where client.action_identifier might be None or empty.
If
client.action_identifier
can be None or an empty string, it might be better to handle these cases explicitly to avoid unexpected output.