✨ feature: adding action_identifier for each client in get_info

[mraniki]

Summary by Sourcery

This pull request enhances the get_info method by including an action_identifier for each client, providing more detailed information.

• New Features:
  • Added action_identifier for each client in the get_info method.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request enhances the get_info method in findmyorder/main.py by adding an action_identifier for each client. The client_info string construction was updated to include this new attribute, providing more detailed information about each client.

File-Level Changes

Files	Changes
findmyorder/main.py	Enhanced the get_info method to display action_identifier for each client.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @mraniki - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion: Consider handling cases where client.action_identifier might be None or empty.

If client.action_identifier can be None or an empty string, it might be better to handle these cases explicitly to avoid unexpected output.

Suggested change

	f"🔎 {client.name}\n🔠 {client.action_identifier}"
	f"🔎 {client.name}\n🔠 {client.action_identifier or 'N/A'}"

[sourcery-ai]

suggestion (performance): Consider the performance impact of the join operation inside a generator expression.

While the current implementation is likely efficient for a small number of clients, if self.clients can be large, it might be worth considering alternative approaches to improve performance.

Suggested change

	for client in self.clients
	client_info = []
	for client in self.clients:
	client_info.append(f"🔎 {client.name}\n🔠 {client.action_identifier}")
	client_info = "".join(client_info)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a6f37d7) to head (29a5f1b).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #382   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          137       137           
=========================================
  Hits           137       137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.