-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't select "Always open in container" on a redirect loop (e.g. splitwise) #640
Comments
Maybe we should do more URL storing as part of the "always open in this container". The only solution I can think of would be to propose other sub domains that the user might also want to containerise. As there isn't a way to know if a subdomain belongs to another we would likely have to store the trace of how the user logged in of unique hostnames. So:
This would add more complexity and potential to break other peoples expectations. I have seen a few issues with the redirection, perhaps we can figure that out another way. |
@mcomella hey are you still seeing this, there have been some updates to assignment however I recognise due to our API limitations it's still not perfect at the moment. |
I'm currently using my workaround so I don't see the issue on a day-to-day basis and I don't have time atm to undo my settings to verify it still occurs. |
Some overlap with #839? |
Possible workaround: for each relevant subdomain involved in the redirection process, get the server to return a See here: #1670 (comment) |
I use splitwise.com. When logged in, splitwise redirects to secure.splitwise.com (note: I also use HTTPSEverywhere so maybe that's why). I flagged secure.splitwise.com to always open in a container but, afaict, without logging out, there's no way to flag splitwise.com to always open in a personal container since every time I open it in a personal container, it goes to secure.splitwise.com. Sometimes, I'll accidentally log in on my non-container tab, which redirects and opens in my container tab.
It feels like a small nag in the UX. I can also imagine there are websites where this becomes a much bigger problem than I'm experiencing.
One way to solve it would be to allow pages to be flagged for "Always open in container" if you're not already in the container tab.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: