-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually add URL's to a container #1670
Comments
Yes please, this would make the extension amazing! I want to be able to add amazon iam-account login links to containers, but they are redirects, which means there is no moment to intercept it and add as "always open" in a selected container. This would allow me to: setup:
usage:
|
Hi @kendallcorner, can you assign this issue to me? |
Further to this: |
I believe this would be better served by being added to Firefox, on the Options page, rather than in the tiny extension pop-up menus. This way we can have a large text box that we can edit and copy/paste into. This would also make moving container assignment to new profiles a matter of copy/pasting. |
Imagine you have 100+ containers. Then the And these two options dont exclude one another. It may be, that the window for copy pasting is just a gui for that text file. For me, it would be extreamly pleasant to have just one descriptive text file and option to point extension to that file to load and set all containers, site lists included. |
I agree with you. Never occurred to me someone would have that many containers lol, but of course Export/Import would be awesome. Right now settings are stored in IndexedDB. You can move that around (storage folder,) but because of ID's etc, it will probably not work in another profile. I still would appreciate a nice textbox, preferably in the options, where I can quickly add and remove stuff from within the browser, by just typing domains, and copy/paste stuff between containers etc. But if Import/Export uses yaml, json or whatnot that will do fine, we can edit that easily enough! |
https://addons.mozilla.org/en-US/firefox/addon/simple-tab-groups/ handles this pretty well, and you can use a regex string too. [EDIT to fix url] |
@jeremymeyers I think your link got wrong-linked... |
@xdhmoore my bad. fixed now. |
I am struggling with this because of redirects... It would be awesome if we could do it, as well as allowing wildards such as |
I have mistakenly posted a similar proposal to bugzilla.mozilla.org. The full text can be read at the link I gave. In general, I support the proposal to add the ability to add dozens and hundreds of domains with all subdomains to containers in the same way as it is done with custom filters in ad blockers. |
I'm surprise to find this isn't a feature, could have a simple check box "always open this site in this container". Seriously, who on earth would want to manually select containers every time they open a new tab? |
Why has this been waiting so long? IT doesn't sound like there's disagreement with the proposal, and @sherry13131 offered to work on it. |
@TriMoon I can tell you from experience working on other projects that have many live bugs referring to the same underlying problem is TERRIBLE; it saps time and energy just dealing with bug triaging, leaving less and less time to work on fixing it. If you want to make a bug more likely to be worked on, make it easier for prospective fixers to deal with the reports: add your comments to the existing bug, don't create new ones. Or if you have some variation that you think warrants a separate issue, and put detailed cross notes with the reference in the main issue, so that the coder who works on fixing it can see whether it's worthwhile reading the other bug to get some detail. One bug report or feature request with 100 comments will be much more likely to get fixed that 3 bug reports with 33 comments each. And 3 bug reports with 100 comments are just going to annoy the fixer for wasting their time. If it's so important to you that it transcends normal etiquette and good manners when dealing with volunteers, consider volunteering yourself to fix it. |
I note that issue #1833 is currently pinned, so it's much more likely to receive attention than any of these related bugs. |
I note that @sherry13131 did work on it and appears to have, if not a complete solution, at least a step in the right direction. However the PR has gone stale for 16 months and so I've rebased it against today's master and re-submitted it as PR #2114. |
Please provide this functionality to manually add a URL to a container. Here is my config:
|
Additional Vote For FunctionalityI also would absolutely like this functionality. FF 99 Nightly I would also suggest the ability for other add-ons to address this one simply via API. So that programs such as firewalls, or script blockers like noscript, can assist in management of sites, and provide even deeper sandboxing of scripts and more per container. The IndexedDB DatabaseWhere is this IndexedDB file, and can I easily edit it in DB Browser (SQLite) or something? (as a scrappy workaround) I've had a look around (including the XPI) and can't find anything obvious. Also, I have what I would've thought as more containers than most. Were 'ABE' still a thing in noscript (it will be again), I'd wholly like to have that and containers fully syncopatio.
|
The only reason I don't have hundreds of site specific containers is because of the awkwardness of the interface for making them work. This issue is a prime example. I'd love it if I could have site-specific containers be the default, and created automatically, though I'm sure there would be many issues to work through. |
Hi team, Any updates on this? Last year I started replacing Google stuff with some non-spying (/less-spying) alternatives. This year I want to focus on opensource or, at least, companies that contribute back to the community (Bitwarden was the very first in this journey). I find Containers extremely useful (I have used to Chrome profiles and I like containers more), but the fact that I can't assign the redirect link to some container, makes them unsusable by a large factor. I have seen a multiple PRs regarding this feature. One of them is still open - #2114. Why this issue is not fixed for years? This is not the case when community doesn't want to contribute - this is, for sure, a very important feature that have got attention from lots of community members and developers. It is not going to break UX for a regular (non-engineering) user, but it will give devoted users a real tool. :( |
I am unable to open e.g. Google Photos without disabling "limit to designated sites" for my Google container. It insists on taking me to through some redirection sequence every time, even if the container is logged in, and I enter some direct link into the app. (This of course is some idiotic design on Google's part--you can't directly type photos.google.com into the address bar and be in the app without first seeing some asinine marketing/landing page and having to click a button.) |
Yeah I think this is exactly the issue that others have been describing in various tickets over the past few years. Below is another workaround that I haven't seen mentioned, yet. Steps:
Painful, but only has to be done once (until Google changes something ;-). |
Referring to my previous comment, I realized that it's not always possible to trigger a In that case, you can just disable redirects in your browser temporarily. In Firefox, there's a setting called Just set it to |
While it would be useful to be able to manually add domains, it would still remain clumsy at best to identify the domains involved in redirects, navigate to the right containers and paste them in. What would be really nice would be to be able to display a list of recent urls, that have been directed outside the container because they didn't match the domain list for the container, ideally including the whole redirect chain up to the point where the page did not redirect. I'd then want a clickable interface to add the domains that I'd prefer not to jump outside the originating container, and they'd get added to that container accordingly. |
@xanoni That 404 method sounds like just the workaround that will do it, thanks. I figured identifying the particular domains would not be too difficult, especially since people will have been complaining about this particular problem already, and you can just pull the domains from their posts. @mc0e You're right that this would benefit from a better interface for getting the redirected domains. But, I expect that some sort of analysis paralysis is what has prevented this feature from being implemented, because it wasn't ever going to be implemented in the perfect way. |
Also, adding the domains to a container that is locked to the domains means that those domains will also ONLY open in that container ... |
Another workaround (because I found some sites where the 404 workaround doesn't apply) is to just go to the extension's inspector window and get/set the right records in the extension's localstorage. Write-up here: https://gist.github.com/philsnow/322bea2867d401171ada1c2eb7a38c89 |
I've been using multi-account containers for years and lack of this feature was always frustrating. |
Now, a couple months later--from @philsnow 's link, I used this snippet: await ( async (prev, next) => {
const prevURL = "siteContainerMap@@_" + prev;
const nextURL = "siteContainerMap@@_" + next;
await browser.storage.local.set({
[nextURL]: (await browser.storage.local.get(prevURL))[prevURL]
});
})("www.example.com", "SOMEWHERE.example.com") replacing
I was able to defeat the login loop on YouTube. I'm not sure whether |
This seems to be the simplest route. Although I wouldn't call it simple by any means. But it works at least. |
Yeah, if were to allegorically speak in ITIL terms and say this whole thing was an incident (I know it isn't) ... then that is not a fix and it is barely a work around. Plus, it's not something that general FireFox users will consider, in that it woud not even factor into their UX. Sorry to just post negativity, it is not my usual thing. 😞
|
Manually adding hosts would surely help, but as I just added yet another site to its own container, I encountered another problem: even if I gradually increased the redirect limit I seemed to miss one domain. I eventually brought up the inspector and from there opened a site in a new tab (with 0 redirect on). From there it was easy to add that domain to the correct container. The solution would be to have something to track which domains a tab has connected, then select and add sites from that list to the container. |
The problem with those redirects is due to automated redirects to a domain that is (automatically) opened with a different container. That sounds to me like a security issue anyway, so FF (or the extension) should either ask the user what to do, with an option to add it to the current container, or just open it in the current container. There is still an issue with javascript or meta forwards, but at least those are delayed somewhat and the user should be able to see the domain in between; Though if it's possible to catch those, I would do that as well. For a workaround, I found it easier using the dev tools network tab. If you enable "persist logs" setting (in cogwheel dropdown), you will also see page redirects, this may be a bit easier to check than playing with redirect-limit. For example if you go to http://google.com you'll get
Now if you're trying to add a new container, just do a full login cycle in a private browsing session (with dev tab open and logs persisting), then filter out all the gunk (images, css, js, xhr, ...) and you'll end up with a list of all domains involved. |
Containers leaking data is a security issue. |
... ... although I could've sworn I saw Firefox handle the 'login' part of all of this automatically the other day. Basically, I was in one container, it opened the login in another, then closed that and refreshed the original to finish the login process. So it's possible that Moz are in the midst of handling the 'login flow over a different domain' thing which is a part of this multi-faceted request. |
Agreed, but containers and MAC in particular seem to be going the tab groups route from the core team support I'm seeing here.
Maybe you were previously logged-in in the origin container and just authorized the app? Logins need to set cookies and those definitely should not be shared across containers, that's the whole point |
Easy workaround to manually add a redirecting url:
I used this to add manually my different AWS accounts to the multi account containers. Or any other link where the url redirects edit: I posted this workaround to help others since it took me some hours to figure out a way to do this and I thought it could help others. It seems this comment has rubbed some people the wrong way. It was not my intention in any way to hurt or annoy anyone, only to help others like me that stumble onto this message thread. |
Very helpful, but this is obviously not a reason to close this.
|
@enikkari It's a good option for those who can do that, but "shutting off the internet connection" is unreasonable where it would disrupt persistent connections such as ssh or irc. A more targetted approach that only blocks new TCP connections would be preferable. One way to do this on Linux is using
To unblock change
You can use The |
I tried to add |
Also affected by this issue, I might have a workaround that's easier. You can replace the URL (and cookieStoreId) with whatever you want to include, and then confirm that, and it will be added correctly. |
Interesting, @jhard, thanks!
So, we'd just then need to know the container ID, one would assume. Plus to be cognisant of domain/subdomain stuff, of course. I wonder how easy it might be to use a userscript to work around/with this. |
Mozilla/5.0 (X11; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0 ID:20200229214828
Other installed Add-ons + Version + Enabled/Disabled-Status (Click to expand/hide)
About Sync 0.0.51
Amazon.com 1.1
Authenticator 6.0.1
Awesome RSS 1.3.5
Bing 1.1
CanvasBlocker 1.1 [DISABLED]
Certainly Something (Certificate Viewer) 1.2.3
Compat Report 0.1.0
Containers theme 1.0.3 [DISABLED]
Context Plus 0.6.0
Debian queries 2.3
Decentraleyes 2.0.13
Disconnect 5.19.3 [DISABLED]
DuckDuckGo 1.0
DuckDuckGo Privacy Essentials 2019.12.12 [DISABLED]
Emoji Cheatsheet for GitHub, Basecamp etc. 2.0.1
Enhancer for YouTube™ 2.0.99
Enterprise Policy Generator 5.1.0 [DISABLED]
Feedbro 4.0.3
Firefox DevTools ADB Extension 0.0.5
Firefox Lightbeam 2.1.0
Firefox Multi-Account Containers 6.2.3
FoxyProxy Standard 7.4.3
Google 1.0
Greasemonkey 4.9
HTTP/2 Indicator 3.0
IPFS Companion 2.10.0
Laboratory 3.0.7 [DISABLED]
MathML Font Settings 0.3.2
Native MathML 1.9.4
Nightly Tester Tools 4.0
Notes by Firefox 4.3.5 [DISABLED]
Offline QR Code Generator 1.6
PassFF 1.9.1 [DISABLED]
Plasma Integration 1.7
ProtonDB for Steam 1.6.0
React Developer Tools 4.4.0 [DISABLED]
Session Sync 3.1.12
Snooze Tabs 1.1.1
Tab Session Manager 5.2.0 [DISABLED]
To Google Translate 4.0.6
Tree Style Tab 3.3.6
True Sight 1.7.1
Twitter 1.0
Vue.js devtools 5.3.3
Wikipedia (en) 1.0
YouTube Container 1.3.0
eBay 1.0
uMatrix 1.4.0
Actual behavior
No way to add redirecting URL's.
Expected behavior
To automatically open known redirect URI's we need a EASY way to add them to a container.
Sometimes you want to catch redirect links, to force them to always open in a certain container before the browser navigates to the destination of the link.
For this purpose we NEED a way to manually add URL's to a container of choice !
Steps to reproduce
https://go.microsoft.com/fwlink/?LinkID=xxxxx&wt.mc_id=fuckmedead
Notes
Related issues: #719, #837, #839, #1057, #1075, #1180, #1335, #1317 and maybe many more im tired search now...
The text was updated successfully, but these errors were encountered: