-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1670 Manually add URL's to a container #1688
Conversation
Issue 1670 ui
added logic for attaching url to container
Issue 1670 backend
remove mandatory www in URL
Hoping this can be merged. It's currently very hard to select "Always open in..." for URLs that redirect. |
Make it happen ! Please ! |
@maxxcrawford @sherry13131 |
Yeeesss please 😍 And it'll fix #1227, too 🙏🎉 |
Meanwhile is there a way to enter sites manually in a file or database? |
@toso here is a config file mentioned #1227 (comment) And maybe this can help even though it looks a little outdated https://excellenttips.wordpress.com/2018/07/05/editing-mozilla-firefox-container-urls/ |
Thx @CanRau, I suppose the handling has changed since the Wordpress page was written in 2018, since this particular folder doesn't contain any data of the Multi-Account Plugin. |
Please someone merge this request. It will be really useful. |
This should happen. The code needs to be refactored because MAC has changed a little in the meantime. For example, methods like |
Hi @sherry13131, just to let you know that I've rebased your code and resubmitted it as PR #2114. I've made some minor changes to cope with merge conflicts, and fixed one bug, but otherwise it's all your work, thankyou. |
Closing in favor of #2114 |
Fixes the issues #1670 Manually add URL's to a container
Implemented:
Demonstration:
![ezgif com-optimize](https://user-images.githubusercontent.com/23732578/76789174-acc99680-6792-11ea-9953-c9574f4b5c89.gif)