Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1670 Manually add URL's to a container #1688

Closed
wants to merge 16 commits into from

Conversation

sherry13131
Copy link

Fixes the issues #1670 Manually add URL's to a container

Implemented:

  • Added an input field in the "edit container" menu of each container
  • Added URL will show immediately once added
  • If the input URL already register to another container, the URL will add to the current one and remove from the previously registered container

Demonstration:
ezgif com-optimize

@sherry13131 sherry13131 changed the title Issue 1670 Fixes #1670 Manually add URL's to a container Apr 7, 2020
@ChrisLane
Copy link

Hoping this can be merged. It's currently very hard to select "Always open in..." for URLs that redirect.

@ikipatang
Copy link

Make it happen ! Please !

@TriMoon
Copy link

TriMoon commented Jul 25, 2020

@maxxcrawford @sherry13131
Why is this being held back so long?
Please fix the conflicts and merge, this is a MUCH needed feature...

@CanRau
Copy link

CanRau commented Sep 20, 2020

Yeeesss please 😍

And it'll fix #1227, too 🙏🎉

@ToS0
Copy link

ToS0 commented Sep 30, 2020

Meanwhile is there a way to enter sites manually in a file or database?

@CanRau
Copy link

CanRau commented Sep 30, 2020

@toso here is a config file mentioned #1227 (comment)

And maybe this can help even though it looks a little outdated https://excellenttips.wordpress.com/2018/07/05/editing-mozilla-firefox-container-urls/

@ToS0
Copy link

ToS0 commented Sep 30, 2020

Thx @CanRau, I suppose the handling has changed since the Wordpress page was written in 2018, since this particular folder doesn't contain any data of the Multi-Account Plugin.
However, I could see that there are a lot of folders and files are created for each container in .../profile/storage/default/ - in addition to the files for other extensions. There are mainly sqlite databases, I can open with the DB Browser and see my data, but since there are probably cross-reference and alike, I don't want to mess with the data directly.
So it seems there is easy way to config -- we need an API at least, better an UI...

@1999masih
Copy link

Please someone merge this request. It will be really useful.

@rhclayto
Copy link

rhclayto commented Feb 6, 2021

This should happen. The code needs to be refactored because MAC has changed a little in the meantime. For example, methods like setOrRemoveAssignment & addEnterHandler are now on the Utils object, not the Logic object. The CSS styling needs to be fixed. And the list of sites assigned to a container is now on a sub-page of the pop-up, not on the contaner's page, as shown in the OP's video.

@grahamperrin
Copy link

#839

@kurahaupo
Copy link

Hi @sherry13131, just to let you know that I've rebased your code and resubmitted it as PR #2114.

I've made some minor changes to cope with merge conflicts, and fixed one bug, but otherwise it's all your work, thankyou.

@dannycolin
Copy link
Collaborator

Closing in favor of #2114

@dannycolin dannycolin closed this Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.