deps(sentry): upgrade Sentry to version 8 #17505
Conversation
chenba
force-pushed
the
fxa-10192-sentry-upgrade
branch
2 times, most recently
from
df55980
to
73793ec
Compare
chenba
force-pushed
the
fxa-10192-sentry-upgrade
branch
from
c1535a0
to
5d440c9
Compare
| @@ -23,7 +24,8 @@ const CODE_WITHOUT_KEYS = 'f0f0f0'; | |||
| const mockDb = { touchSessionToken: sinon.stub() }; | |||
| const mockStatsD = { increment: sinon.stub() }; | |||
| const mockGlean = { oauth: { tokenCreated: sinon.stub() } }; | |||
| const tokenRoutes = proxyquire('../../../lib/routes/oauth/token', { | |||
| const tokenRoutePath = path.join(__dirname, '../../../lib/routes/oauth/token'); | |||
chenba
force-pushed
the
fxa-10192-sentry-upgrade
branch
4 times, most recently
from
d58c600
to
6c030f1
Compare
|
I'm putting this up for an initial review. But at the time of writing (mid-Sept), we've exceed the tracing quota on all projects(?) but the content server, making verification difficult. |
| @@ -120,6 +115,7 @@ async function configureSentry(server, config, processName = 'key_server') { | |||
| method(request, h) { | |||
| request.sentryScope = new Sentry.Scope(); | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
I commented out the code block below and didn't notice any difference. But it's entirely possible I was not looking in the right place. Maybe @dschom can let me know what I should look for. 🙇
There was a problem hiding this comment.
Nice. That would indicate to me that the auto instrumentation is now capturing spans. I wonder if we even need this server extension at all anymore?
| Sentry.browserTracingIntegration({ | ||
| enableInp: true, | ||
| }), | ||
| ], |
There was a problem hiding this comment.
Most integrations are now automatic.
dschom
force-pushed
the
fxa-10192-sentry-upgrade
branch
14 times, most recently
from
a681f2c
to
d5f5fd9
Compare
|
Setting the PR back to draft for now as we've noticed some performance issues with Sentry 8.x. |
Because: - Sentry 8 is the latest version This commit: - deletes some integration code since Sentry does it automatically - updates code to use the Sentry 8 API - updates a few proxyquire calls because they were cause module not found errors in CI
dschom
force-pushed
the
fxa-10192-sentry-upgrade
branch
from
d5f5fd9
to
74b337f
Compare
package.json
Outdated
There was a problem hiding this comment.
@chenba @dschom just wanted to mention the resolutions of @sentry/types. Seems like it's fine to remove that now.
dschom
force-pushed
the
fxa-10192-sentry-upgrade
branch
from
74b337f
to
90e9d8a
Compare
Becuase: - After upgrading sentry we were seeing test timeouts - There were some kinda weird patterns in place for these tests anyways - Test server wasn't getting cleaned up - Test server start up is taking longer (presumably because of sentry upgrade?) This Commit: - Moves before an after blocks next to each other so setup and tear down are easy to follow - Makes sure test server start / stop is done in before each blocks - Increase test timeouts to 60s when test server is used - Switches to async/await for before and after blocks, which feels less error prone
dschom
force-pushed
the
fxa-10192-sentry-upgrade
branch
from
90e9d8a
to
0394075
Compare
Because:
This commit:
found errors in CI