feat(next): add sentry to payments-next #17550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaberindeZA
commented
Sep 6, 2024
| @@ -276,7 +277,8 @@ | |||
| "tap/typescript": "^4.5.2", | |||
| "terser:>4.0.0 <5": ">=4.8.1", | |||
| "terser:>5 <6": ">=5.14.2", | |||
| "underscore": ">=1.13.2" | |||
| "underscore": ">=1.13.2", | |||
| "@sentry/types": "^7.113.0" | |||
There was a problem hiding this comment.
This should be removed once #17505 is merged.
| @@ -61,6 +61,7 @@ | |||
| "@fxa/shared/pem-jwk": ["libs/shared/pem-jwk/src/index.ts"], | |||
| "@fxa/shared/react": ["libs/shared/react/src/index.ts"], | |||
| "@fxa/shared/sentry": ["libs/shared/sentry/src/index.ts"], | |||
| "@fxa/shared/sentry/client": ["libs/shared/sentry/src/client.ts"], | |||
There was a problem hiding this comment.
Some modules in shared-sentry require modules only available in a node environment, such as fs, which are not available on the client (browser). Therefore a separate client barrel file is required which would not include these modules.
StaberindeZA
force-pushed
the
fxa-9998-add-sentry-payments
branch
3 times, most recently
from
69cc7bf
to
fe1c51e
Compare
StaberindeZA
force-pushed
the
fxa-9998-add-sentry-payments
branch
from
fe1c51e
to
0e50f05
Compare
Because: - Be able to use Sentry in Next.js on both the client and the server This commit: - Add Sentry to payments-next using the installation wizard Closes #FXA-9998
StaberindeZA
force-pushed
the
fxa-9998-add-sentry-payments
branch
from
0e50f05
to
54fefd2
Compare
julianpoy
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-9998
Checklist
Put an
xin the boxes that apply