Fix mozilla/thimble.mozilla.org#1887: File overwrites without notifying user

[humphd]

Finishing work begun by @Simon66 in #712. I've rebased it and fixed some bugs, but I need to do another round of cleanup on this before it's ready for review, which I'll do soon.

[humphd]

OK, this is ready for review. Here's what it does, and how to test:

• Drag some new file image.png into your file tree. You shouldn't get a dialog, and the file should import correctly.
• Drag the same file image.png into your file tree again. This time you should get a dialog asking if you want to keep the existing file, use the new one, or cancel. Try repeating this process with all 3 options, and each should do what you expect.
• Repeat the above process for a .zip file
• Repeat the above process for a .tar file

[flukeout]

Testing now.

[flukeout]

Some suggestions this popup...

• Let's just have two actions on the popup...
  • Use New File (Green)
  • Cancel (Gray)
• Change the copy a bit....

Suggested popup...

[flukeout]

Use the upload file dialog and drag in a file that already exists. Then, select "Keep Existing". The upload dialog stays open with the "Uploading..." spinner visible, like this...

I think we should just close the upload dialog once the "Choose what to do" dialog opens.

Another small thing
This is totally an edge case, but if you drag in two files with the same name, this is the result...

This is a bit different in terms of behavior because we rename instead of prompting about duplication.

[flukeout]

Functionally this is working great. Let's address...

• Popup content & buttons
• Fixing the "upload dialog" issue

[humphd]

Good catch on the upload spinner--I fixed that originally, but somehow lost that part of the commit, maybe in a rebase. It's fixed now.

This is totally an edge case, but if you drag in two files with the same name, this is the result...

I don't know what this means. How do you drag in two files with the same name (e.g. your OS won't allow it).

Let's just have two actions on the popup...

We should discuss this a bit. The idea of the Cancel action is that you can stop the entire import. For example, if I drag in a zip file, and already have all the files, I don't want to have to click "Keep Existing" 50 times.

[flukeout]

^^^ What's up now @humphd ?!?!!?

Anyway, let me revisit the popup actions with multiple duplicated files. I hadn't tried that.

[flukeout]

If I drag in two files, both of which are duplicates, the popup shows up twice. Cancel dismissed each popup, but doesn't cancel the entire import.

If I drag in a ZIP file with two duplicated files, then I can cancel the entire upload process with the first click of Cancel - which also doesn't feel right, since it only references one file.

For the case of multiple files being duplicated, we could list them all in the popup, or say, there are some duplicate files here, [overwrite all] or [keep existing] for all

[humphd]

Talking with Luke, we're going to try doing this:

• Try to do "Keep All" or "Replace All" vs. one-by-one for an import. That is, remember what the user says for an import "session" then clear that and ask again next time.

@flukeout to figure out the dialog strings.

[flukeout]

@humph Dialog strings... thoughts?

We found a file with the same name

There is already a file called coin.mp3 in your project. We can overwrite it with the new file or keep the existing file.

[ Keep all existing files ] [ Use new files ]

[humphd]

I think that we should be careful about mixing the idea of this specific file vs. all files. The dialog message and the buttons aren't aligned in that way. What about this:

We found a file with the same name

There is already a file called coin.mp3 in your project. We can keep the existing file(s), or overwrite with the new file(s).

[ Keep all existing files ] [ Use new files ]